You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2021/10/01 18:49:24 UTC
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17893
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
IMPALA-10942: Fix memory leak in admission controller
This patch fixes a memory leak in the admission controller where
objects tracking state required for queuing where being retained
despite the query being admitted or rejected immediately.
Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
---
M be/src/scheduling/admission-control-service.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/local-admission-control-client.cc
4 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/17893/2
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 2: Code-Review+2
OK I see the note in the Jira answering my question.
Approving assuming spelling nit is fixed
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 20:46:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7518/
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Mon, 04 Oct 2021 22:53:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 4:
GVO failed earlier due to flaky test. Re-running
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Tue, 05 Oct 2021 18:18:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, abeltian, Riza Suminto, David Rorke, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17893
to look at the new patch set (#3).
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
IMPALA-10942: Fix memory leak in admission controller
This patch fixes a memory leak in the admission controller where
objects tracking state required for queuing were being retained
despite the query being admitted or rejected immediately.
Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
---
M be/src/scheduling/admission-control-service.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/local-admission-control-client.cc
4 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/17893/3
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Mon, 04 Oct 2021 16:41:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7518/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Mon, 04 Oct 2021 16:41:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7522/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 5
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Tue, 05 Oct 2021 18:19:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "abeltian (Code Review)" <ge...@cloudera.org>.
abeltian has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 2: Code-Review+1
> Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Sat, 02 Oct 2021 03:25:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 5
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Tue, 05 Oct 2021 18:19:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
IMPALA-10942: Fix memory leak in admission controller
This patch fixes a memory leak in the admission controller where
objects tracking state required for queuing were being retained
despite the query being admitted or rejected immediately.
Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Reviewed-on: http://gerrit.cloudera.org:8080/17893
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/scheduling/admission-control-service.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/local-admission-control-client.cc
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 6
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 5
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 00:27:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9546/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 19:11:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 21:07:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 2:
(2 comments)
QQ to see if I understand what is going on
http://gerrit.cloudera.org:8080/#/c/17893/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17893/2//COMMIT_MSG@10
PS2, Line 10: objects tracking state required for queuing where being retained
Nit: "were" being retained
http://gerrit.cloudera.org:8080/#/c/17893/2//COMMIT_MSG@12
PS2, Line 12:
Is the point of this change that this code is wrong in the old version because queued was a pointer and so never zero (false)?
const auto queue_node_deleter = MakeScopeExitTrigger([&]()
{
if (!queued) {
lock_guard<mutex> lock(queue_nodes_lock_);
queue_nodes_.erase(request.query_id);
}
});
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 20:41:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 )
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Comment-Date: Mon, 04 Oct 2021 16:41:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has removed a vote on this change.
Change subject: IMPALA-10942: Fix memory leak in admission controller
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/17893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1df0de0e658f6dcb5a044d108d0943aaa3dea0a1
Gerrit-Change-Number: 17893
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>