[GitHub] [hive] asolimando commented on a change in pull request #2685: Hive 25530: AssertionError when query involves multiple JDBC tables and views

[GitBox <gi...@apache.org>]

asolimando commented on a change in pull request #2685:
URL: https://github.com/apache/hive/pull/2685#discussion_r726828332



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -1612,6 +1613,10 @@ private RowResolver genRowResolver(Operator op, QB qb) {
     private final StatsSource statsSource;
     private RelNode dummyTableScan;
 
+    // these variables are to ensure that they get instantiated only once
+    Map<List<String>, JdbcConvention> jcMap = new HashMap<>();

Review comment:
       Nit: nowadays with autocompletion I think we can afford longer and self-explanatory variable names like `jdbcConventionMap`, WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org