[GitHub] [spark] HyukjinKwon commented on pull request #29938: [SPARK-33061][SQL] Expose inverse hyperbolic trig functions through sql.functions API

[GitBox <gi...@apache.org>]

HyukjinKwon commented on pull request #29938:
URL: https://github.com/apache/spark/pull/29938#issuecomment-703370465


   There have been some discussions about which functions to add. Basically some expressions exist in SparkSQL core just for the sake of other DBMS compatibility. In other language APIs, some expressions make less sense.
   
   It's better to make simplify the call and when to add so it ended up with writing as so at https://github.com/apache/spark/pull/29938#issuecomment-703132270. Let's avoid adding functions there just for the sake of matching.
   
   How often are they used? I don't know enough about that. cc @WeichenXu123 or @srowen. Are they used commonly in daily data science? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org