You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "karan singh malhi (JIRA)" <ji...@apache.org> on 2007/08/05 13:56:52 UTC
[jira] Created: (OPENEJB-624) Extract Logger Categories to a
separate interface
Extract Logger Categories to a separate interface
-------------------------------------------------
Key: OPENEJB-624
URL: https://issues.apache.org/jira/browse/OPENEJB-624
Project: OpenEJB
Issue Type: Improvement
Components: general
Reporter: karan singh malhi
Priority: Minor
If the logger names could be extracted to constants in an interface,
then it will be easier to make changes to logger names and will also
lead to lesser errors , because logger names are case sensitive
So for example, instead of obtaining a logger like
public static final Logger logger =
Logger.getInstance("OpenEJB.startup",
Assembler.class.getPackage().getName());
We could do something like
public static final Logger logger =
Logger.getInstance(LogCategory.OPENEJB_STARTUP,
Assembler.class.getPackage().getName());
In fact, with static import it will just be
public static final Logger logger =
Logger.getInstance(OPENEJB_STARTUP,
Assembler.class.getPackage().getName());
LogCategory would contain the names of all loggers used in openejb.
Since there are just a few loggers, they could be defined within the
Logger class itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENEJB-624) Extract Logger Categories to a
separate interface
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
karan singh malhi updated OPENEJB-624:
--------------------------------------
Attachment: openejb-624.patch
Fixed this issue. However, javadoc still needs to be added for each Logger Category.
> Extract Logger Categories to a separate interface
> -------------------------------------------------
>
> Key: OPENEJB-624
> URL: https://issues.apache.org/jira/browse/OPENEJB-624
> Project: OpenEJB
> Issue Type: Improvement
> Components: general
> Reporter: karan singh malhi
> Priority: Minor
> Attachments: openejb-624.patch
>
>
> If the logger names could be extracted to constants in an interface,
> then it will be easier to make changes to logger names and will also
> lead to lesser errors , because logger names are case sensitive
> So for example, instead of obtaining a logger like
> public static final Logger logger =
> Logger.getInstance("OpenEJB.startup",
> Assembler.class.getPackage().getName());
> We could do something like
> public static final Logger logger =
> Logger.getInstance(LogCategory.OPENEJB_STARTUP,
> Assembler.class.getPackage().getName());
> In fact, with static import it will just be
> public static final Logger logger =
> Logger.getInstance(OPENEJB_STARTUP,
> Assembler.class.getPackage().getName());
> LogCategory would contain the names of all loggers used in openejb.
> Since there are just a few loggers, they could be defined within the
> Logger class itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OPENEJB-624) Extract Logger Categories to a
separate interface
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Blevins reassigned OPENEJB-624:
-------------------------------------
Assignee: karan singh malhi
> Extract Logger Categories to a separate interface
> -------------------------------------------------
>
> Key: OPENEJB-624
> URL: https://issues.apache.org/jira/browse/OPENEJB-624
> Project: OpenEJB
> Issue Type: Improvement
> Components: general
> Reporter: karan singh malhi
> Assignee: karan singh malhi
> Priority: Minor
> Fix For: 3.0
>
> Attachments: openejb-624.patch
>
>
> If the logger names could be extracted to constants in an interface,
> then it will be easier to make changes to logger names and will also
> lead to lesser errors , because logger names are case sensitive
> So for example, instead of obtaining a logger like
> public static final Logger logger =
> Logger.getInstance("OpenEJB.startup",
> Assembler.class.getPackage().getName());
> We could do something like
> public static final Logger logger =
> Logger.getInstance(LogCategory.OPENEJB_STARTUP,
> Assembler.class.getPackage().getName());
> In fact, with static import it will just be
> public static final Logger logger =
> Logger.getInstance(OPENEJB_STARTUP,
> Assembler.class.getPackage().getName());
> LogCategory would contain the names of all loggers used in openejb.
> Since there are just a few loggers, they could be defined within the
> Logger class itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OPENEJB-624) Extract Logger Categories to a
separate interface
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Blevins closed OPENEJB-624.
---------------------------------
Resolution: Fixed
Fix Version/s: 3.0
Great patch, Karan!
$ svn ci container
Sending container/openejb-core/src/main/java/org/apache/openejb/OpenEJB.java
Sending container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
Sending container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/InterceptorBindingBuilder.java
Sending container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/JndiBuilder.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/AnnotationDeployer.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/AutoConfig.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/ConfigUtils.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/ConfigurationFactory.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/DeploymentLoader.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/EjbJarInfoBuilder.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/EjbJarUtils.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/InitEjbDeployments.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/JndiEncInfoBuilder.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/OutputGeneratedDescriptors.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/ServiceUtils.java
Sending container/openejb-core/src/main/java/org/apache/openejb/config/ValidateEjbModule.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/CoreDeploymentInfo.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/CoreUserTransaction.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/ThreadContext.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/entity/EntityContainer.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/entity/EntityInstanceManager.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/ivm/EjbHomeProxyHandler.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/ivm/EjbObjectProxyHandler.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/mdb/MdbContainer.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/mdb/MdbInstanceFactory.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/PropertiesLoginModule.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/stateful/SessionSynchronizationCoordinator.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/stateful/SimplePassivater.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulInstanceManager.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/timer/DatabaseTimerStore.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/timer/EjbTimerServiceImpl.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/timer/MemoryTimerStore.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/timer/TimerData.java
Sending container/openejb-core/src/main/java/org/apache/openejb/core/transaction/TransactionPolicy.java
Sending container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/JdbcLocalTransaction.java
Sending container/openejb-core/src/main/java/org/apache/openejb/resource/jdbc/JdbcManagedConnectionFactory.java
Sending container/openejb-core/src/main/java/org/apache/openejb/ri/sp/PseudoTransactionService.java
Sending container/openejb-core/src/main/java/org/apache/openejb/util/DirectoryMonitor.java
Adding container/openejb-core/src/main/java/org/apache/openejb/util/LogCategory.java
Sending container/openejb-core/src/main/java/org/apache/openejb/util/OpenEJBErrorHandler.java
Transmitting file data ..........................................
Committed revision 562964.
> Extract Logger Categories to a separate interface
> -------------------------------------------------
>
> Key: OPENEJB-624
> URL: https://issues.apache.org/jira/browse/OPENEJB-624
> Project: OpenEJB
> Issue Type: Improvement
> Components: general
> Reporter: karan singh malhi
> Assignee: karan singh malhi
> Priority: Minor
> Fix For: 3.0
>
> Attachments: openejb-624.patch
>
>
> If the logger names could be extracted to constants in an interface,
> then it will be easier to make changes to logger names and will also
> lead to lesser errors , because logger names are case sensitive
> So for example, instead of obtaining a logger like
> public static final Logger logger =
> Logger.getInstance("OpenEJB.startup",
> Assembler.class.getPackage().getName());
> We could do something like
> public static final Logger logger =
> Logger.getInstance(LogCategory.OPENEJB_STARTUP,
> Assembler.class.getPackage().getName());
> In fact, with static import it will just be
> public static final Logger logger =
> Logger.getInstance(OPENEJB_STARTUP,
> Assembler.class.getPackage().getName());
> LogCategory would contain the names of all loggers used in openejb.
> Since there are just a few loggers, they could be defined within the
> Logger class itself.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.