You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "aswinad (via GitHub)" <gi...@apache.org> on 2026/06/21 15:58:40 UTC
[PR] SLING-13244 Strengthen RequestProcessorMBean reset statistics test [sling-org-apache-sling-engine]
aswinad opened a new pull request, #79:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/79
This strengthens the resetStatistics() coverage in RequestProcessorMBeanImplTest.
The test now covers both the single-sample post-reset case and a second sample
where min, max, and mean differ. This verifies the reset statistics accessors
more directly, including getMaxPeakRecursionDepth().
Jira: SLING-13244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13244 Strengthen RequestProcessorMBean reset statistics test [sling-org-apache-sling-engine]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert merged PR #79:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13244 Strengthen RequestProcessorMBean reset statistics test [sling-org-apache-sling-engine]
Posted by "aswinad (via GitHub)" <gi...@apache.org>.
aswinad commented on code in PR #79:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/79#discussion_r3456887858
##########
src/test/java/org/apache/sling/engine/impl/RequestProcessorMBeanImplTest.java:
##########
@@ -132,58 +132,64 @@ public void test_statistics() throws NotCompliantMBeanException {
// is reinitialized
bean.resetStatistics();
- // Simulate a single request
- final long durationValue = min + random.nextInt(max - min);
- final int callCountValue = min + random.nextInt(max - min);
- final int peakRecursionDepthValue = min + random.nextInt(max - min);
+ final RequestData firstRequestDataAfterReset = Mockito.mock(RequestData.class, "firstRequestDataAfterReset");
+ Mockito.when(firstRequestDataAfterReset.getElapsedTimeMsec()).thenReturn(100L);
+ Mockito.when(firstRequestDataAfterReset.getServletCallCount()).thenReturn(10);
+ Mockito.when(firstRequestDataAfterReset.getPeakRecusionDepth()).thenReturn(5);
- final RequestData requestData = Mockito.mock(RequestData.class, "requestDataAfterReset");
- Mockito.when(requestData.getElapsedTimeMsec()).thenReturn(durationValue);
- Mockito.when(requestData.getServletCallCount()).thenReturn(callCountValue);
- Mockito.when(requestData.getPeakRecusionDepth()).thenReturn(peakRecursionDepthValue);
+ final RequestData secondRequestDataAfterReset = Mockito.mock(RequestData.class, "secondRequestDataAfterReset");
+ Mockito.when(secondRequestDataAfterReset.getElapsedTimeMsec()).thenReturn(200L);
+ Mockito.when(secondRequestDataAfterReset.getServletCallCount()).thenReturn(20);
+ Mockito.when(secondRequestDataAfterReset.getPeakRecusionDepth()).thenReturn(15);
- bean.addRequestData(requestData);
+ bean.addRequestData(firstRequestDataAfterReset);
- // As only one request has been simulated since resetStatiscts: min, max and mean statistics should be equals to
- // the request data
assertEquals("After resetStatistics Number of requests must be one", 1, bean.getRequestsCount());
- assertEquals("After resetStatistics Min Duration must be equal", bean.getMinRequestDurationMsec(), (long)
- durationValue);
- assertEquals("After resetStatistics Max Duration must be equal", bean.getMaxRequestDurationMsec(), (long)
- durationValue);
+ assertEquals("After resetStatistics Min Duration must be equal", 100L, bean.getMinRequestDurationMsec());
+ assertEquals("After resetStatistics Max Duration must be equal", 100L, bean.getMaxRequestDurationMsec());
+ assertEquals("After resetStatistics Mean Duration must be equal", 100.0, bean.getMeanRequestDurationMsec(), 0d);
assertEquals(
- "After resetStatistics Mean Duration must be equal",
- bean.getMeanRequestDurationMsec(),
- (double) durationValue,
+ "After resetStatistics Standard Deviation Duration must be zero",
+ 0.0,
+ bean.getStandardDeviationDurationMsec(),
0d);
+ assertEquals("After resetStatistics Min Servlet Call Count must be equal", 10, bean.getMinServletCallCount());
+ assertEquals("After resetStatistics Max Servlet Call Count must be equal", 10, bean.getMaxServletCallCount());
+ assertEquals("After resetStatistics Mean Servlet Call Count", 10.0, bean.getMeanServletCallCount(), 0d);
assertEquals(
- "After resetStatistics Min Servlet Call Count must be equal",
- bean.getMinServletCallCount(),
- callCountValue);
- assertEquals(
- "After resetStatistics Max Servlet Call Count must be equal",
- bean.getMaxServletCallCount(),
- callCountValue);
- assertEquals(
- "After resetStatistics Mean Servlet Call Count",
- bean.getMeanServletCallCount(),
- (double) callCountValue,
+ "After resetStatistics Standard Deviation Servlet Call Count must be zero",
+ 0.0,
+ bean.getStandardDeviationServletCallCount(),
0d);
assertEquals(
- "After resetStatistics Min Peak Recursion Depth must be equal",
- bean.getMinPeakRecursionDepth(),
- peakRecursionDepthValue);
+ "After resetStatistics Min Peak Recursion Depth must be equal", 5, bean.getMinPeakRecursionDepth());
assertEquals(
- "After resetStatistics Max Peak Recursion Depth must be equal",
- bean.getMinPeakRecursionDepth(),
- peakRecursionDepthValue);
+ "After resetStatistics Max Peak Recursion Depth must be equal", 5, bean.getMaxPeakRecursionDepth());
+ assertEquals("After resetStatistics Mean Peak Recursion Depth", 5.0, bean.getMeanPeakRecursionDepth(), 0d);
assertEquals(
- "After resetStatistics Mean Peak Recursion Depth",
- bean.getMeanPeakRecursionDepth(),
- (double) peakRecursionDepthValue,
+ "After resetStatistics Standard Deviation Peak Recursion Depth must be zero",
+ 0.0,
+ bean.getStandardDeviationPeakRecursionDepth(),
0d);
+
+ bean.addRequestData(secondRequestDataAfterReset);
+
+ assertEquals("After resetStatistics Number of requests must be two", 2, bean.getRequestsCount());
Review Comment:
Agreed, that’s clearer. I’ve updated the assertions after adding the second request to use “After processing second request”, so the failure messages describe the state being checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13244 Strengthen RequestProcessorMBean reset statistics test [sling-org-apache-sling-engine]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #79:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/79#issuecomment-4762524464
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=79) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=79&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=79&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=79&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=79&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=79&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=79)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13244 Strengthen RequestProcessorMBean reset statistics test [sling-org-apache-sling-engine]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #79:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/79#issuecomment-4775434469
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=79) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=79&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=79&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine&pullRequest=79&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=79&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine&pullRequest=79&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine&pullRequest=79)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13244 Strengthen RequestProcessorMBean reset statistics test [sling-org-apache-sling-engine]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on code in PR #79:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/79#discussion_r3452075120
##########
src/test/java/org/apache/sling/engine/impl/RequestProcessorMBeanImplTest.java:
##########
@@ -132,58 +132,64 @@ public void test_statistics() throws NotCompliantMBeanException {
// is reinitialized
bean.resetStatistics();
- // Simulate a single request
- final long durationValue = min + random.nextInt(max - min);
- final int callCountValue = min + random.nextInt(max - min);
- final int peakRecursionDepthValue = min + random.nextInt(max - min);
+ final RequestData firstRequestDataAfterReset = Mockito.mock(RequestData.class, "firstRequestDataAfterReset");
+ Mockito.when(firstRequestDataAfterReset.getElapsedTimeMsec()).thenReturn(100L);
+ Mockito.when(firstRequestDataAfterReset.getServletCallCount()).thenReturn(10);
+ Mockito.when(firstRequestDataAfterReset.getPeakRecusionDepth()).thenReturn(5);
- final RequestData requestData = Mockito.mock(RequestData.class, "requestDataAfterReset");
- Mockito.when(requestData.getElapsedTimeMsec()).thenReturn(durationValue);
- Mockito.when(requestData.getServletCallCount()).thenReturn(callCountValue);
- Mockito.when(requestData.getPeakRecusionDepth()).thenReturn(peakRecursionDepthValue);
+ final RequestData secondRequestDataAfterReset = Mockito.mock(RequestData.class, "secondRequestDataAfterReset");
+ Mockito.when(secondRequestDataAfterReset.getElapsedTimeMsec()).thenReturn(200L);
+ Mockito.when(secondRequestDataAfterReset.getServletCallCount()).thenReturn(20);
+ Mockito.when(secondRequestDataAfterReset.getPeakRecusionDepth()).thenReturn(15);
- bean.addRequestData(requestData);
+ bean.addRequestData(firstRequestDataAfterReset);
- // As only one request has been simulated since resetStatiscts: min, max and mean statistics should be equals to
- // the request data
assertEquals("After resetStatistics Number of requests must be one", 1, bean.getRequestsCount());
- assertEquals("After resetStatistics Min Duration must be equal", bean.getMinRequestDurationMsec(), (long)
- durationValue);
- assertEquals("After resetStatistics Max Duration must be equal", bean.getMaxRequestDurationMsec(), (long)
- durationValue);
+ assertEquals("After resetStatistics Min Duration must be equal", 100L, bean.getMinRequestDurationMsec());
+ assertEquals("After resetStatistics Max Duration must be equal", 100L, bean.getMaxRequestDurationMsec());
+ assertEquals("After resetStatistics Mean Duration must be equal", 100.0, bean.getMeanRequestDurationMsec(), 0d);
assertEquals(
- "After resetStatistics Mean Duration must be equal",
Review Comment:
Any particular reason to change the assertion? If you think this is worthwile adding you can do that but keep the existing one as well.
##########
src/test/java/org/apache/sling/engine/impl/RequestProcessorMBeanImplTest.java:
##########
@@ -132,58 +132,64 @@ public void test_statistics() throws NotCompliantMBeanException {
// is reinitialized
bean.resetStatistics();
- // Simulate a single request
- final long durationValue = min + random.nextInt(max - min);
- final int callCountValue = min + random.nextInt(max - min);
- final int peakRecursionDepthValue = min + random.nextInt(max - min);
+ final RequestData firstRequestDataAfterReset = Mockito.mock(RequestData.class, "firstRequestDataAfterReset");
+ Mockito.when(firstRequestDataAfterReset.getElapsedTimeMsec()).thenReturn(100L);
+ Mockito.when(firstRequestDataAfterReset.getServletCallCount()).thenReturn(10);
+ Mockito.when(firstRequestDataAfterReset.getPeakRecusionDepth()).thenReturn(5);
- final RequestData requestData = Mockito.mock(RequestData.class, "requestDataAfterReset");
- Mockito.when(requestData.getElapsedTimeMsec()).thenReturn(durationValue);
- Mockito.when(requestData.getServletCallCount()).thenReturn(callCountValue);
- Mockito.when(requestData.getPeakRecusionDepth()).thenReturn(peakRecursionDepthValue);
+ final RequestData secondRequestDataAfterReset = Mockito.mock(RequestData.class, "secondRequestDataAfterReset");
+ Mockito.when(secondRequestDataAfterReset.getElapsedTimeMsec()).thenReturn(200L);
+ Mockito.when(secondRequestDataAfterReset.getServletCallCount()).thenReturn(20);
+ Mockito.when(secondRequestDataAfterReset.getPeakRecusionDepth()).thenReturn(15);
- bean.addRequestData(requestData);
+ bean.addRequestData(firstRequestDataAfterReset);
- // As only one request has been simulated since resetStatiscts: min, max and mean statistics should be equals to
- // the request data
assertEquals("After resetStatistics Number of requests must be one", 1, bean.getRequestsCount());
- assertEquals("After resetStatistics Min Duration must be equal", bean.getMinRequestDurationMsec(), (long)
- durationValue);
- assertEquals("After resetStatistics Max Duration must be equal", bean.getMaxRequestDurationMsec(), (long)
- durationValue);
+ assertEquals("After resetStatistics Min Duration must be equal", 100L, bean.getMinRequestDurationMsec());
+ assertEquals("After resetStatistics Max Duration must be equal", 100L, bean.getMaxRequestDurationMsec());
+ assertEquals("After resetStatistics Mean Duration must be equal", 100.0, bean.getMeanRequestDurationMsec(), 0d);
assertEquals(
- "After resetStatistics Mean Duration must be equal",
- bean.getMeanRequestDurationMsec(),
- (double) durationValue,
+ "After resetStatistics Standard Deviation Duration must be zero",
+ 0.0,
+ bean.getStandardDeviationDurationMsec(),
0d);
+ assertEquals("After resetStatistics Min Servlet Call Count must be equal", 10, bean.getMinServletCallCount());
+ assertEquals("After resetStatistics Max Servlet Call Count must be equal", 10, bean.getMaxServletCallCount());
+ assertEquals("After resetStatistics Mean Servlet Call Count", 10.0, bean.getMeanServletCallCount(), 0d);
assertEquals(
- "After resetStatistics Min Servlet Call Count must be equal",
- bean.getMinServletCallCount(),
- callCountValue);
- assertEquals(
- "After resetStatistics Max Servlet Call Count must be equal",
- bean.getMaxServletCallCount(),
- callCountValue);
- assertEquals(
- "After resetStatistics Mean Servlet Call Count",
- bean.getMeanServletCallCount(),
- (double) callCountValue,
+ "After resetStatistics Standard Deviation Servlet Call Count must be zero",
+ 0.0,
+ bean.getStandardDeviationServletCallCount(),
0d);
assertEquals(
- "After resetStatistics Min Peak Recursion Depth must be equal",
- bean.getMinPeakRecursionDepth(),
- peakRecursionDepthValue);
+ "After resetStatistics Min Peak Recursion Depth must be equal", 5, bean.getMinPeakRecursionDepth());
assertEquals(
- "After resetStatistics Max Peak Recursion Depth must be equal",
- bean.getMinPeakRecursionDepth(),
- peakRecursionDepthValue);
+ "After resetStatistics Max Peak Recursion Depth must be equal", 5, bean.getMaxPeakRecursionDepth());
+ assertEquals("After resetStatistics Mean Peak Recursion Depth", 5.0, bean.getMeanPeakRecursionDepth(), 0d);
assertEquals(
- "After resetStatistics Mean Peak Recursion Depth",
- bean.getMeanPeakRecursionDepth(),
- (double) peakRecursionDepthValue,
+ "After resetStatistics Standard Deviation Peak Recursion Depth must be zero",
+ 0.0,
+ bean.getStandardDeviationPeakRecursionDepth(),
0d);
+
+ bean.addRequestData(secondRequestDataAfterReset);
+
+ assertEquals("After resetStatistics Number of requests must be two", 2, bean.getRequestsCount());
Review Comment:
Please changes these assertions to say "After processing second request" instead of "After reseStatistics" since it's more accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13244 Strengthen RequestProcessorMBean reset statistics test [sling-org-apache-sling-engine]
Posted by "aswinad (via GitHub)" <gi...@apache.org>.
aswinad commented on code in PR #79:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/79#discussion_r3456884888
##########
src/test/java/org/apache/sling/engine/impl/RequestProcessorMBeanImplTest.java:
##########
@@ -132,58 +132,64 @@ public void test_statistics() throws NotCompliantMBeanException {
// is reinitialized
bean.resetStatistics();
- // Simulate a single request
- final long durationValue = min + random.nextInt(max - min);
- final int callCountValue = min + random.nextInt(max - min);
- final int peakRecursionDepthValue = min + random.nextInt(max - min);
+ final RequestData firstRequestDataAfterReset = Mockito.mock(RequestData.class, "firstRequestDataAfterReset");
+ Mockito.when(firstRequestDataAfterReset.getElapsedTimeMsec()).thenReturn(100L);
+ Mockito.when(firstRequestDataAfterReset.getServletCallCount()).thenReturn(10);
+ Mockito.when(firstRequestDataAfterReset.getPeakRecusionDepth()).thenReturn(5);
- final RequestData requestData = Mockito.mock(RequestData.class, "requestDataAfterReset");
- Mockito.when(requestData.getElapsedTimeMsec()).thenReturn(durationValue);
- Mockito.when(requestData.getServletCallCount()).thenReturn(callCountValue);
- Mockito.when(requestData.getPeakRecusionDepth()).thenReturn(peakRecursionDepthValue);
+ final RequestData secondRequestDataAfterReset = Mockito.mock(RequestData.class, "secondRequestDataAfterReset");
+ Mockito.when(secondRequestDataAfterReset.getElapsedTimeMsec()).thenReturn(200L);
+ Mockito.when(secondRequestDataAfterReset.getServletCallCount()).thenReturn(20);
+ Mockito.when(secondRequestDataAfterReset.getPeakRecusionDepth()).thenReturn(15);
- bean.addRequestData(requestData);
+ bean.addRequestData(firstRequestDataAfterReset);
- // As only one request has been simulated since resetStatiscts: min, max and mean statistics should be equals to
- // the request data
assertEquals("After resetStatistics Number of requests must be one", 1, bean.getRequestsCount());
- assertEquals("After resetStatistics Min Duration must be equal", bean.getMinRequestDurationMsec(), (long)
- durationValue);
- assertEquals("After resetStatistics Max Duration must be equal", bean.getMaxRequestDurationMsec(), (long)
- durationValue);
+ assertEquals("After resetStatistics Min Duration must be equal", 100L, bean.getMinRequestDurationMsec());
+ assertEquals("After resetStatistics Max Duration must be equal", 100L, bean.getMaxRequestDurationMsec());
+ assertEquals("After resetStatistics Mean Duration must be equal", 100.0, bean.getMeanRequestDurationMsec(), 0d);
assertEquals(
- "After resetStatistics Mean Duration must be equal",
Review Comment:
Good point, thanks. I meant this as an additional check, not as a replacement for the existing mean-duration assertion. I’ve updated the test to keep the single-request mean assertion and add the standard-deviation check alongside it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org