You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by inbar stolberg <no...@github.com> on 2013/10/22 20:19:54 UTC
[jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added more
options: password, name, ipv6 and ipv4 addresses. (#189)
new PR from : https://github.com/jclouds/jclouds/pull/181
You can merge this Pull Request by running:
git pull https://github.com/inbarsto/jclouds-1 rebuildServer2
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/189
-- Commit Summary --
* JCLOUDS-350 rebuild server for Openstack NOVA added more options: password, name, ipv6 and ipv4 addresses.
-- File Changes --
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/options/RebuildServerOptions.java (70)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ServerApiExpectTest.java (23)
M apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ServerApiLiveTest.java (49)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/189.patch
https://github.com/jclouds/jclouds/pull/189.diff
Re: [jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added
more options: password, name, ipv6 and ipv4 addresses. (#189)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #812](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/812/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/189#issuecomment-26832889
Re: [jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added
more options: password, name, ipv6 and ipv4 addresses. (#189)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #556](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/556/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/189#issuecomment-26836717
Re: [jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added
more options: password, name, ipv6 and ipv4 addresses. (#189)
Posted by Andrew Phillips <no...@github.com>.
Thanks for submitting, @inbarsto!
Could you have a look at the formatting (3-space indents for jclouds vs. 4 spaces) and submit a follow-up PR where necessary? Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/189#issuecomment-26868924
Re: [jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added
more options: password, name, ipv6 and ipv4 addresses. (#189)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #555](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/555/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/189#issuecomment-26828191
Re: [jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added
more options: password, name, ipv6 and ipv4 addresses. (#189)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #348](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/348/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/189#issuecomment-26828382
Re: [jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added
more options: password, name, ipv6 and ipv4 addresses. (#189)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #349](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/349/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/189#issuecomment-26832870
Re: [jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added
more options: password, name, ipv6 and ipv4 addresses. (#189)
Posted by inbar stolberg <no...@github.com>.
https://issues.apache.org/jira/browse/JCLOUDS-350
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/189#issuecomment-26831819
Re: [jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added
more options: password, name, ipv6 and ipv4 addresses. (#189)
Posted by Andrew Phillips <no...@github.com>.
> + } finally {
> + serverApi.delete(serverId);
> + }
> + }
> + }
> +
> + private Server createServer(String regionId, Server.Status serverStatus) {
> + ServerApi serverApi = api.getServerApiForZone(regionId);
> + CreateServerOptions options = new CreateServerOptions();
> + ServerCreated server = serverApi.create(hostName, imageIdForZone(regionId), flavorRefForZone(regionId), options);
> +
> + blockUntilServerInState(server.getId(), serverApi, serverStatus);
> +
> + return serverApi.get(server.getId());
> + }
> +
Formatting looks off here - 4 spaces instead of 3?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/189/files#r7145083
Re: [jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added
more options: password, name, ipv6 and ipv4 addresses. (#189)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #811](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/811/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/189#issuecomment-26828308
Re: [jclouds] JCLOUDS-350 rebuild server for Openstack NOVA added
more options: password, name, ipv6 and ipv4 addresses. (#189)
Posted by Everett Toews <no...@github.com>.
Nice work @inbarsto
+1!
Merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/189#issuecomment-26862233