[GitHub] [accumulo] milleruntime commented on a diff in pull request #2616: Clear encryption data when no longer needed

[GitBox <gi...@apache.org>]

milleruntime commented on code in PR #2616:
URL: https://github.com/apache/accumulo/pull/2616#discussion_r846022359


##########
core/src/main/java/org/apache/accumulo/core/spi/crypto/AESCryptoService.java:
##########
@@ -200,6 +207,15 @@ public void setEncFek(byte[] encFek) {
       this.encFek = encFek;
     }
 
+    @Override
+    public void close() throws Exception {
+      cryptoServiceName = null;
+      cryptoServiceVersion = null;
+      keyManagerVersion = null;
+      kekId = null;
+      Arrays.fill(encFek, (byte) 0);
+    }
+

Review Comment:
   These changes look good so far. I like using AutoCloseable, that is a good idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org