[GitHub] [accumulo] milleruntime commented on a change in pull request #1614: Create max tablets property in new bulk import

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #1614:
URL: https://github.com/apache/accumulo/pull/1614#discussion_r428054872



##########
File path: test/src/main/java/org/apache/accumulo/test/functional/BulkNewIT.java
##########
@@ -183,6 +184,23 @@ public void testSingleTabletSingleFileOffline() throws Exception {
     }
   }
 
+  @Test
+  public void testMaxTablets() throws Exception {
+    String maxTablets = "0";
+    try (AccumuloClient client = Accumulo.newClient().from(getClientProps()).build()) {
+      maxTablets = client.instanceOperations().getSystemConfiguration()
+          .get(Property.MASTER_BULK_MAX_TABLETS.getKey());
+      client.instanceOperations().setProperty(Property.MASTER_BULK_MAX_TABLETS.getKey(), "1");
+      testBulkFile(false, false);
+      fail("Expected IllegalArgumentException for " + Property.MASTER_BULK_MAX_TABLETS);
+    } catch (IllegalArgumentException e) {} finally {
+      try (AccumuloClient client = Accumulo.newClient().from(getClientProps()).build()) {

Review comment:
       I was thinking of the situation where an exception other than IllegalArgumentException is thrown, the property won't be changed back.  Typically this doesn't matter, but I was under the impression we are still striving towards getting the ITs to work as a standalone cluster (even if its still currently fails).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org