You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/09 01:26:11 UTC

[GitHub] [flink] kezhuw opened a new pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

kezhuw opened a new pull request #13989:
URL: https://github.com/apache/flink/pull/13989


   ## What is the purpose of the change
   Synchronize `fetchers.isEmpty` status to `SourceReaderBase` using `elementsQueue.notifyAvailable()`.
   
   ## Brief change log
   * Add test case to fail empty queue assumption in `SourceReaderBase.finishedOrAvailableLater`.
   * Correct empty queue assumption by returning `InputStatus.MORE_AVAILABLE` if not empty.
   * Synchronize `fetchers.isEmpty` status to `SourceReaderBase` using `elementsQueue.notifyAvailable()`.
   
   ## Verifying this change
   This change is already covered by existing tests, such as:
   *  `CoordinatedSourceITCase.testEnumeratorReaderCommunication`.
   
   This change added tests and can be verified as follows:
   * `SourceReaderBaseTest.testMultipleSplitsWithSeparatedFinishedRecord`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] asfgit closed pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #13989:
URL: https://github.com/apache/flink/pull/13989


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723704219


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 5da43fd50d04596217e89f547f97dbb4711ca7ee (Mon Nov 09 01:28:42 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] kezhuw commented on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
kezhuw commented on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-724740105


   @flinkbot run travis
   
   Rerun test ci due to probably unrelated [failure](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=9368&view=logs&j=c88eea3b-64a0-564d-0031-9fdcd7b8abee&t=ff888d9b-cd34-53cc-d90f-3e446d355529&l=20962).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723709607


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325",
       "triggerID" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330",
       "triggerID" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5da43fd50d04596217e89f547f97dbb4711ca7ee Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325) 
   * 7769826c671c1c7e081128ab1a5cf74819808456 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723709607


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5da43fd50d04596217e89f547f97dbb4711ca7ee UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723709607


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325",
       "triggerID" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330",
       "triggerID" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9368",
       "triggerID" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "724740105",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 1ae89af64c82b8cb9782dd5975f636a795ca978e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9368) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723709607


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325",
       "triggerID" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330",
       "triggerID" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9368",
       "triggerID" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9368",
       "triggerID" : "724740105",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 1ae89af64c82b8cb9782dd5975f636a795ca978e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9368) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] kezhuw commented on a change in pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
kezhuw commented on a change in pull request #13989:
URL: https://github.com/apache/flink/pull/13989#discussion_r520212476



##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/SourceReaderBase.java
##########
@@ -270,7 +270,9 @@ private InputStatus finishedOrAvailableLater() {
 			splitFetcherManager.checkErrors();
 			return InputStatus.END_OF_INPUT;
 		} else {
-			throw new IllegalStateException("Called 'finishedOrAvailableLater()' with shut-down fetchers but non-empty queue");
+			// We may fall in this method because of purely finished splits record. If all splits

Review comment:
       @StephanEwen I have changed the comment to what you recommend in fixup commit. In addition to this, I add another fixup commit with new test case `testMultipleSplitsWithDifferentFinishingMoments` which I think is more common than `testMultipleSplitsWithSeparatedFinishedRecord`. After changes, I think the comment covers general concurrent problem while not tied to a specific case, in my opinion.
   
   Both above fixup commits should be squashed out before merging.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] kezhuw commented on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
kezhuw commented on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-724032576


   @flinkbot attention @StephanEwen @becketqin 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] StephanEwen commented on a change in pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on a change in pull request #13989:
URL: https://github.com/apache/flink/pull/13989#discussion_r520080247



##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/SourceReaderBase.java
##########
@@ -270,7 +270,9 @@ private InputStatus finishedOrAvailableLater() {
 			splitFetcherManager.checkErrors();
 			return InputStatus.END_OF_INPUT;
 		} else {
-			throw new IllegalStateException("Called 'finishedOrAvailableLater()' with shut-down fetchers but non-empty queue");
+			// We may fall in this method because of purely finished splits record. If all splits

Review comment:
       Maybe change this to:
   
   > We can reach this case if we just processed all data from the queue and finished a split, and concurrently the fetcher finished another split, whose data is then in the queue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723709607


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325",
       "triggerID" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5da43fd50d04596217e89f547f97dbb4711ca7ee Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325) 
   * 7769826c671c1c7e081128ab1a5cf74819808456 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723709607


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325",
       "triggerID" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330",
       "triggerID" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7769826c671c1c7e081128ab1a5cf74819808456 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330) 
   * 1ae89af64c82b8cb9782dd5975f636a795ca978e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723709607


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325",
       "triggerID" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330",
       "triggerID" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9368",
       "triggerID" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7769826c671c1c7e081128ab1a5cf74819808456 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330) 
   * 1ae89af64c82b8cb9782dd5975f636a795ca978e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9368) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723709607


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325",
       "triggerID" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330",
       "triggerID" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9368",
       "triggerID" : "1ae89af64c82b8cb9782dd5975f636a795ca978e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1ae89af64c82b8cb9782dd5975f636a795ca978e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9368) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723709607


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325",
       "triggerID" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330",
       "triggerID" : "7769826c671c1c7e081128ab1a5cf74819808456",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7769826c671c1c7e081128ab1a5cf74819808456 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9330) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13989: [FLINK-19448][connector/common] Synchronize fetchers.isEmpty status to SourceReaderBase using elementsQueue.notifyAvailable()

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13989:
URL: https://github.com/apache/flink/pull/13989#issuecomment-723709607


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325",
       "triggerID" : "5da43fd50d04596217e89f547f97dbb4711ca7ee",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5da43fd50d04596217e89f547f97dbb4711ca7ee Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9325) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org