You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org> on 2011/12/29 19:41:31 UTC
[jira] [Commented] (ZOOKEEPER-1050) zooinspector shell scripts do
not work
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177313#comment-13177313 ]
Hadoop QA commented on ZOOKEEPER-1050:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501330/ZOOKEEPER-1050.patch
against trunk revision 1225352.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/869//console
This message is automatically generated.
> zooinspector shell scripts do not work
> --------------------------------------
>
> Key: ZOOKEEPER-1050
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1050
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib
> Affects Versions: 3.3.2
> Reporter: Chris Burroughs
> Priority: Trivial
> Labels: zooinspector
> Attachments: ZOOKEEPER-1050.patch
>
>
> * zooInspector-dev.sh uses DOS line endings. Dash at least chokes on this.
> * zooInspector.sh has an errant ; in the classpath.
> Also there really isn't a reason to hard code the zookeeper version needed in lib. Just use a glob.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira