[GitHub] [tvm] vvchernov commented on a diff in pull request #14209: [MetaSchedule][ARM] Enable ARM CPU intrinsic for MetaSchedule

["vvchernov (via GitHub)" <gi...@apache.org>]

vvchernov commented on code in PR #14209:
URL: https://github.com/apache/tvm/pull/14209#discussion_r1130486874


##########
include/tvm/meta_schedule/schedule_rule.h:
##########
@@ -180,7 +180,7 @@ class ScheduleRule : public runtime::ObjectRef {
    * \return The schedule rule created
    */
   TVM_DLL static ScheduleRule MultiLevelTilingWithIntrin(
-      String intrin_name, String structure, Optional<Array<String>> tile_binds,
+      Array<String> intrin_name, String structure, Optional<Array<String>> tile_binds,

Review Comment:
   I understand why it is done (String -> Array<String>), but it should be rethink one more time due to API changing affects other places not only your own task



##########
src/meta_schedule/space_generator/space_generator.cc:
##########
@@ -110,6 +155,16 @@ void SpaceGeneratorNode::InitializeWithTuneContext(const TuneContext& context) {
       default_sch_rules = ScheduleRule::DefaultMicro();
       default_postprocs = Postproc::DefaultMicro();
       default_mutator_probs = Mutator::DefaultMicro();
+    } else if (kind == "neon") {

Review Comment:
   It looks like different levels of target types are checked here. Possibly it should be "arm" type with splitting to "neon"/"dotprod" in separated method.



##########
src/meta_schedule/schedule_rule/multi_level_tiling_with_intrin.cc:
##########
@@ -85,21 +101,23 @@ class MultiLevelTilingWithIntrinNode : public MultiLevelTilingNode {
 
  public:
   /*! \brief The name of a tensor intrinsic. */
-  String intrin_name;
+  Array<String> intrin_name;

Review Comment:
   if the field type is still be changed, I recommend to rename it to `intrin_names` for the sake of clarity



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org