You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/08/06 21:56:12 UTC
Review Request 24419: Check docker validation status code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24419/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
Check docker validation status code
Diffs
-----
src/docker/docker.cpp ee9c882bffd0d410c0083943fcbe1ca6de278ded
Diff: https://reviews.apache.org/r/24419/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24419: Check docker validation status code
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24419/#review49806
-----------------------------------------------------------
Ship it!
src/docker/docker.cpp
<https://reviews.apache.org/r/24419/#comment87164>
include the error code in the error.
- Vinod Kone
On Aug. 6, 2014, 7:56 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24419/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 7:56 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check docker validation status code
>
>
> Diffs
> -----
>
> src/docker/docker.cpp ee9c882bffd0d410c0083943fcbe1ca6de278ded
>
> Diff: https://reviews.apache.org/r/24419/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24419: Check docker validation status code
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24419/#review49819
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 6, 2014, 9:35 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24419/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 9:35 p.m.)
>
>
> Review request for drill and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/24419
>
>
> Diffs
> -----
>
> src/docker/docker.cpp ee9c882bffd0d410c0083943fcbe1ca6de278ded
>
> Diff: https://reviews.apache.org/r/24419/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 24419: Check docker validation status code
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24419/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 9:43 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
Review: https://reviews.apache.org/r/24419
Diffs
-----
src/docker/docker.cpp ee9c882bffd0d410c0083943fcbe1ca6de278ded
Diff: https://reviews.apache.org/r/24419/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 24419: Check docker validation status code
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24419/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 9:35 p.m.)
Review request for drill and Vinod Kone.
Changes
-------
Addressed review comments, and remove unused io and stdout code.
Repository: mesos-git
Description (updated)
-------
Review: https://reviews.apache.org/r/24419
Diffs (updated)
-----
src/docker/docker.cpp ee9c882bffd0d410c0083943fcbe1ca6de278ded
Diff: https://reviews.apache.org/r/24419/diff/
Testing
-------
make check
Thanks,
Timothy Chen