You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/12 09:36:16 UTC
[GitHub] [maven-site] gnodet opened a new pull request, #329: Change code style to refer to the one from maven-shared-resources
gnodet opened a new pull request, #329:
URL: https://github.com/apache/maven-site/pull/329
PR following up https://github.com/apache/maven-shared-resources/pull/1 to use a single reference for code style formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] cstamas commented on pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #329:
URL: https://github.com/apache/maven-site/pull/329#issuecomment-1275966753
Maybe point the download links to gitbox instead of a "just a mirror" GH?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] gnodet commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993305918
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
YES ! A single file is used. The recent versions of IDEA allow importing eclipse config files 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] gnodet commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993305918
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
@slawekjaranowski YES ! A single file is used. The recent versions of IDEA allow importing eclipse config files 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] cstamas commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993327594
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
@slawekjaranowski Eclipse Interoperability plugin disabled maybe? (by default is enabled, unless you tampered with it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] gnodet merged pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
gnodet merged PR #329:
URL: https://github.com/apache/maven-site/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #329:
URL: https://github.com/apache/maven-site/pull/329#issuecomment-1276087750
@cstamas `Eclipse Interoperability` helps 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] gnodet commented on pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #329:
URL: https://github.com/apache/maven-site/pull/329#issuecomment-1276546403
> I tested importing importing eclipse formats ... into InteliJ, We have missing configurations for:
>
> * imports order - settings -> Code Style -> Java - imports tab has default values
>
> how we will manage it?
Meh, you're right.
We could tell users that imports won't be sorted and that they need to either add those or rely on the impsort plugin wich will fix those.
Alternatively, we can add back idea settings, but I'd rather avoid it. We can generate it by importing the eclipse settings into IDEA, fix the import settings to comply with maven code style and export those settings. But we'd have to put them in maven-shared-resources also I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] cstamas commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993318888
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
But this is NOT a "latest" IDEA feature at all, it is since a while, that IDEA supports eclipse XML import....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993315469
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
I don't see such options:
IntelliJ IDEA 2022.2.2 (Ultimate Edition)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] gnodet commented on pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #329:
URL: https://github.com/apache/maven-site/pull/329#issuecomment-1276026664
Btw, given we enforce a 120 characters hard break on lines, I wonder if we should switch to header formatted in the same way, something like
```
/*
* Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements.
* See the NOTICE file distributed with this work for additional information regarding copyright ownership.
* The ASF licenses this file to you under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License is
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and limitations under the License.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] gnodet commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993329409
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
<img width="923" alt="image" src="https://user-images.githubusercontent.com/84022/195330215-71dc8258-36bd-4ffc-a2fd-edac18a6746e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] gnodet commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993323438
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
<img width="1094" alt="image" src="https://user-images.githubusercontent.com/84022/195328105-e517952b-6445-426f-aa44-81411c43d159.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] gnodet commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993319091
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
Same as @cstamas on 2022.2.1 Community Edition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993304231
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
Link is for eclipse-formatter-config.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] cstamas commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993325329
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
This is supported since 2014 it seems https://blog.jetbrains.com/idea/2014/01/intellij-idea-13-importing-code-formatter-settings-from-eclipse/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] cstamas commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993317454
##########
content/apt/developers/conventions/code.apt:
##########
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download <<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download <<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #329:
URL: https://github.com/apache/maven-site/pull/329#issuecomment-1276505031
I tested importing importing eclipse formats ... into InteliJ,
We have missing configurations for:
- imports order - settings -> Code Style -> Java - imports tab has default values
how we will manage it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on pull request #329: Change code style to refer to the one from maven-shared-resources
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #329:
URL: https://github.com/apache/maven-site/pull/329#issuecomment-1276656396
> > I tested importing importing eclipse formats ... into InteliJ, We have missing configurations for:
> >
> > * imports order - settings -> Code Style -> Java - imports tab has default values
> >
> > how we will manage it?
>
> Meh, you're right.
>
> We could tell users that imports won't be sorted and that they need to either add those or rely on the impsort plugin wich will fix those.
>
> Alternatively, we can add back idea settings, but I'd rather avoid it. We can generate it by importing the eclipse settings into IDEA, fix the import settings to comply with maven code style and export those settings. But we'd have to put them in maven-shared-resources also I suppose.
I'm for preserve native settings for InteliJ, it can be in m-shared-r.
I hope that not will be changed so frequently, so we can do such manual works as you describe, to have synchronized Eclipse and InteliJ.
It will be easier for user to simply import settings.
We have also import settings for eclipse in https://github.com/apache/maven-site/blob/master/content/resources/developers/maven-eclipse.importorder so this file should be moved to shared to have everything in one place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org