You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Yoshikazu Nojima <ma...@ynojima.net> on 2013/10/29 01:52:01 UTC
Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't created
correctly in rare case when vxlan is used for isolation method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/
-----------------------------------------------------------
Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
Bugs: CLOUDSTACK-4967
https://issues.apache.org/jira/browse/CLOUDSTACK-4967
Repository: cloudstack-git
Description
-------
Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
This patch fix this issue by raising error when long interface name is specified.
Issue remained: document that physical interface name length must be shorter than 5.
Diffs
-----
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/15001/diff/
Testing
-------
I confirmed it passes the unit tests I add.
Thanks,
Yoshikazu Nojima
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't
created correctly in rare case when vxlan is used for isolation method
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27733
-----------------------------------------------------------
Commit 4a9f05bda075d03c4a5a015e081c70b3d8b72267 in branch refs/heads/master from Marcus Sorensen
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4a9f05b ]
CLOUDSTACK-4967
1) vxlan will use bridge scheme 'brvx-<vni>'. Multiple physical networks can host guest
traffic type with vxlan isolation, so long as they don't use the same VNI range.
2) Guest traffic labels can be physical interface if bridge by given name is not found.
Normally we take traffic label name, find the matching bridge, then resolve that to a
physical interface. Then we create guest bridges on that interface. Now we can just
specify the interface.
- ASF Subversion and Git Services
On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 12:51 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
>
> Issue remained: document that physical interface name length must be shorter than 5.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15001/diff/
>
>
> Testing
> -------
>
> I confirmed it passes the unit tests I add.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't
created correctly in rare case when vxlan is used for isolation method
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> >
>
> Toshiaki Hatano wrote:
> Actual issue is not "the physical interface name length must be shorter than 5" but "generated bridge name cannot exceed 15 character".
>
>
> Yoshikazu Nojima wrote:
> If we check generated bridge name length, users will not face the exception before their cloudstack environment grow up. They will face the exception in production environment suddenly.
> If we check physical interface name length, users can face the exception whenever bridge name length is not enough.
>
>
> Toshiaki Hatano wrote:
> That's why we would note in document that such a situation can be happened when VXLAN isolated zone grows up, isn't it?
>
> It's too much to completely disable VXLAN isolation for pifName >=5, especially when we won't provide any workaround.
> IMO when we try to introduce fool proof mechanism, like this patch, we first try to avoid creating restriction in non-fools' usage.
>
> Let's check Marcus's patch.
User can change a vlan interface name by configuration.
http://manpages.ubuntu.com/manpages/raring/man5/vlan-interfaces.5.html
I think it is enough workaround. isn't it?
- Yoshikazu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------
On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 12:51 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
>
> Issue remained: document that physical interface name length must be shorter than 5.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15001/diff/
>
>
> Testing
> -------
>
> I confirmed it passes the unit tests I add.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't
created correctly in rare case when vxlan is used for isolation method
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java, line 158
> > <https://reviews.apache.org/r/15001/diff/2/?file=372880#file372880line158>
> >
> > If we checked length here, generated brName should be checked, not a pifName.
> >
> > We shouldn't block valid brName by this check, e.g. eth0.1000-9000.
>
> Toshiaki Hatano wrote:
> s/eth0.1000-9000/breth0.100-9000/
It validates pifName, not brName. It validates pifName in the point of whether it is appropriate to be used for generating bridge name here.
- Yoshikazu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------
On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 12:51 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
>
> Issue remained: document that physical interface name length must be shorter than 5.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15001/diff/
>
>
> Testing
> -------
>
> I confirmed it passes the unit tests I add.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't
created correctly in rare case when vxlan is used for isolation method
Posted by Toshiaki Hatano <ha...@haeena.net>.
> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> >
Actual issue is not "the physical interface name length must be shorter than 5" but "generated bridge name cannot exceed 15 character".
> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java, line 158
> > <https://reviews.apache.org/r/15001/diff/2/?file=372880#file372880line158>
> >
> > If we checked length here, generated brName should be checked, not a pifName.
> >
> > We shouldn't block valid brName by this check, e.g. eth0.1000-9000.
s/eth0.1000-9000/breth0.100-9000/
- Toshiaki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------
On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 12:51 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
>
> Issue remained: document that physical interface name length must be shorter than 5.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15001/diff/
>
>
> Testing
> -------
>
> I confirmed it passes the unit tests I add.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't
created correctly in rare case when vxlan is used for isolation method
Posted by Toshiaki Hatano <ha...@haeena.net>.
> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java, line 158
> > <https://reviews.apache.org/r/15001/diff/2/?file=372880#file372880line158>
> >
> > If we checked length here, generated brName should be checked, not a pifName.
> >
> > We shouldn't block valid brName by this check, e.g. eth0.1000-9000.
>
> Toshiaki Hatano wrote:
> s/eth0.1000-9000/breth0.100-9000/
>
> Yoshikazu Nojima wrote:
> It validates pifName, not brName. It validates pifName in the point of whether it is appropriate to be used for generating bridge name here.
My apology if it was lack of talk.
What I trid to mean is, brName like "breth0.100-9000" are still valid bridge name despite pifName longer than 5, thus this check is too strong.
- Toshiaki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------
On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 12:51 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
>
> Issue remained: document that physical interface name length must be shorter than 5.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15001/diff/
>
>
> Testing
> -------
>
> I confirmed it passes the unit tests I add.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't
created correctly in rare case when vxlan is used for isolation method
Posted by Toshiaki Hatano <ha...@haeena.net>.
> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> >
>
> Toshiaki Hatano wrote:
> Actual issue is not "the physical interface name length must be shorter than 5" but "generated bridge name cannot exceed 15 character".
>
>
> Yoshikazu Nojima wrote:
> If we check generated bridge name length, users will not face the exception before their cloudstack environment grow up. They will face the exception in production environment suddenly.
> If we check physical interface name length, users can face the exception whenever bridge name length is not enough.
>
That's why we would note in document that such a situation can be happened when VXLAN isolated zone grows up, isn't it?
It's too much to completely disable VXLAN isolation for pifName >=5, especially when we won't provide any workaround.
IMO when we try to introduce fool proof mechanism, like this patch, we first try to avoid creating restriction in non-fools' usage.
Let's check Marcus's patch.
- Toshiaki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------
On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 12:51 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
>
> Issue remained: document that physical interface name length must be shorter than 5.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15001/diff/
>
>
> Testing
> -------
>
> I confirmed it passes the unit tests I add.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't
created correctly in rare case when vxlan is used for isolation method
Posted by Marcus Sorensen <sh...@gmail.com>.
> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> >
>
> Toshiaki Hatano wrote:
> Actual issue is not "the physical interface name length must be shorter than 5" but "generated bridge name cannot exceed 15 character".
>
>
> Yoshikazu Nojima wrote:
> If we check generated bridge name length, users will not face the exception before their cloudstack environment grow up. They will face the exception in production environment suddenly.
> If we check physical interface name length, users can face the exception whenever bridge name length is not enough.
>
>
> Toshiaki Hatano wrote:
> That's why we would note in document that such a situation can be happened when VXLAN isolated zone grows up, isn't it?
>
> It's too much to completely disable VXLAN isolation for pifName >=5, especially when we won't provide any workaround.
> IMO when we try to introduce fool proof mechanism, like this patch, we first try to avoid creating restriction in non-fools' usage.
>
> Let's check Marcus's patch.
>
> Yoshikazu Nojima wrote:
> User can change a vlan interface name by configuration.
> http://manpages.ubuntu.com/manpages/raring/man5/vlan-interfaces.5.html
>
> I think it is enough workaround. isn't it?
>From what I've tried in the past, given the Vlan tag 1000, you can implement that via name "eth0.1000" or "vlan1000", but that's it. Unless something has changed, you can't create an arbitrary short name. So that leaves only 3-4 characters for vni.
Ah, see set_name_type for vconfig, it describes these allowed names.
- Marcus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------
On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 12:51 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
>
> Issue remained: document that physical interface name length must be shorter than 5.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15001/diff/
>
>
> Testing
> -------
>
> I confirmed it passes the unit tests I add.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't
created correctly in rare case when vxlan is used for isolation method
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> >
>
> Toshiaki Hatano wrote:
> Actual issue is not "the physical interface name length must be shorter than 5" but "generated bridge name cannot exceed 15 character".
>
>
> Yoshikazu Nojima wrote:
> If we check generated bridge name length, users will not face the exception before their cloudstack environment grow up. They will face the exception in production environment suddenly.
> If we check physical interface name length, users can face the exception whenever bridge name length is not enough.
>
>
> Toshiaki Hatano wrote:
> That's why we would note in document that such a situation can be happened when VXLAN isolated zone grows up, isn't it?
>
> It's too much to completely disable VXLAN isolation for pifName >=5, especially when we won't provide any workaround.
> IMO when we try to introduce fool proof mechanism, like this patch, we first try to avoid creating restriction in non-fools' usage.
>
> Let's check Marcus's patch.
>
> Yoshikazu Nojima wrote:
> User can change a vlan interface name by configuration.
> http://manpages.ubuntu.com/manpages/raring/man5/vlan-interfaces.5.html
>
> I think it is enough workaround. isn't it?
>
> Marcus Sorensen wrote:
> From what I've tried in the past, given the Vlan tag 1000, you can implement that via name "eth0.1000" or "vlan1000", but that's it. Unless something has changed, you can't create an arbitrary short name. So that leaves only 3-4 characters for vni.
>
> Ah, see set_name_type for vconfig, it describes these allowed names.
>
>
Oh, I didn't know that.. It breaks this patch's assumption.
- Yoshikazu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------
On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 12:51 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
>
> Issue remained: document that physical interface name length must be shorter than 5.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15001/diff/
>
>
> Testing
> -------
>
> I confirmed it passes the unit tests I add.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't
created correctly in rare case when vxlan is used for isolation method
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote:
> >
>
> Toshiaki Hatano wrote:
> Actual issue is not "the physical interface name length must be shorter than 5" but "generated bridge name cannot exceed 15 character".
>
If we check generated bridge name length, users will not face the exception before their cloudstack environment grow up. They will face the exception in production environment suddenly.
If we check physical interface name length, users can face the exception whenever bridge name length is not enough.
- Yoshikazu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------
On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 12:51 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
>
> Issue remained: document that physical interface name length must be shorter than 5.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15001/diff/
>
>
> Testing
> -------
>
> I confirmed it passes the unit tests I add.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15001: CLOUDSTACK-4967: Bugfix: Guest network isn't
created correctly in rare case when vxlan is used for isolation method
Posted by Toshiaki Hatano <ha...@haeena.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15001/#review27657
-----------------------------------------------------------
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
<https://reviews.apache.org/r/15001/#comment53719>
If we checked length here, generated brName should be checked, not a pifName.
We shouldn't block valid brName by this check, e.g. eth0.1000-9000.
- Toshiaki Hatano
On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15001/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 12:51 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Guest network isn't created correctly when vxlan is used for isolation method, VNI is bigger than 10000000, and physical network interface name length is longer than 4.
> This patch fix this issue by raising error when long interface name is specified.
>
> Issue remained: document that physical interface name length must be shorter than 5.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java f945b74
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15001/diff/
>
>
> Testing
> -------
>
> I confirmed it passes the unit tests I add.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>