You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by relaxdiego <gi...@git.apache.org> on 2016/06/16 08:24:28 UTC

[GitHub] libcloud pull request #815: Indicate listener ip

GitHub user relaxdiego opened a pull request:

    https://github.com/apache/libcloud/pull/815

    Indicate listener ip

    ## Changes Title (replace this with a logical title for your changes)
    
    ### Description
    
    The documentation for the Dimension Data Cloud REST API v2.2-20160222 states that a load balancer can be statically assigned a listener IP on creation. This change fixes the dimension data driver to conform to the docs.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/relaxdiego/libcloud indicate_listener_ip

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/815.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #815
    
----
commit ca10bbdafb0ec353fb57bc57ebb61283c9841387
Author: Mark S. Maglana <mm...@gmail.com>
Date:   2016-06-16T04:47:47Z

    Allow setting of load balancer port to None
    
    The documentation for the Dimension Data Cloud REST API v2.2-20160222
    states that a load balancer port can be an integer in the range of
    1-65535 and, if not supplied, will be taken to mean 'Any Port'
    
    This change fixes the libcloud driver to conform to the docs.

commit b7877bf58b2a2ff1bda7dddef97af5ea0a3ed02e
Author: Mark S. Maglana <mm...@gmail.com>
Date:   2016-06-16T08:21:50Z

    Allow setting of load balancer listener IP
    
    The documentation for the Dimension Data Cloud REST API v2.2-20160222
    states that a load balancer can be statically assigned a listener IP
    on creation. This change fixes the dimension data driver to conform
    to the docs.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #815: Indicate listener ip

Posted by relaxdiego <gi...@git.apache.org>.
Github user relaxdiego closed the pull request at:

    https://github.com/apache/libcloud/pull/815


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---