You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by michael goulish <mg...@redhat.com> on 2015/06/03 19:47:48 UTC
Review Request 35016: Declare static functions static,
and change their names to pni_*
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35016/
-----------------------------------------------------------
Review request for qpid, Kenneth Giusti and Ted Ross.
Repository: qpid-proton-git
Description
-------
I only changed functions that were not mentioned in public .h files, and that were only called from within their file.
A few were not called at all -- and I removed those.
Diffs
-----
proton-c/src/buffer.c 145292a
proton-c/src/codec/codec.c e8750fe
proton-c/src/codec/decoder.c dbbb13f
proton-c/src/engine/engine-internal.h 2f0cc56
proton-c/src/engine/engine.c 67cc882
proton-c/src/object/list.c 14231f6
proton-c/src/object/map.c c969d24
proton-c/src/parser.c 93b6da4
proton-c/src/scanner.c ef54db4
proton-c/src/transport/transport.c e72875b
Diff: https://reviews.apache.org/r/35016/diff/
Testing
-------
It still compiles, and all unit tests still work.
Thanks,
michael goulish
Re: Review Request 35016: Declare static functions static,
and change their names to pni_*
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35016/#review86630
-----------------------------------------------------------
proton-c/src/buffer.c
<https://reviews.apache.org/r/35016/#comment138678>
Did you miss the "static" here?
- Andrew Stitcher
On June 3, 2015, 5:49 p.m., michael goulish wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35016/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 5:49 p.m.)
>
>
> Review request for qpid, Kenneth Giusti and Ted Ross.
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> I only changed functions that were not mentioned in public .h files, and that were only called from within their file.
>
> A few were not called at all -- and I removed those.
>
> I made no other changes except declaring functions static, and changing the prefix on their names to pni_ .
>
>
> Diffs
> -----
>
> proton-c/src/buffer.c 145292a
> proton-c/src/codec/codec.c e8750fe
> proton-c/src/codec/decoder.c dbbb13f
> proton-c/src/engine/engine-internal.h 2f0cc56
> proton-c/src/engine/engine.c 67cc882
> proton-c/src/object/list.c 14231f6
> proton-c/src/object/map.c c969d24
> proton-c/src/parser.c 93b6da4
> proton-c/src/scanner.c ef54db4
> proton-c/src/transport/transport.c e72875b
>
> Diff: https://reviews.apache.org/r/35016/diff/
>
>
> Testing
> -------
>
> It still compiles, and all unit tests still work.
>
>
> Thanks,
>
> michael goulish
>
>
Re: Review Request 35016: Declare static functions static,
and change their names to pni_*
Posted by michael goulish <mg...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35016/
-----------------------------------------------------------
(Updated June 3, 2015, 5:49 p.m.)
Review request for qpid, Kenneth Giusti and Ted Ross.
Repository: qpid-proton-git
Description (updated)
-------
I only changed functions that were not mentioned in public .h files, and that were only called from within their file.
A few were not called at all -- and I removed those.
I made no other changes except declaring functions static, and changing the prefix on their names to pni_ .
Diffs
-----
proton-c/src/buffer.c 145292a
proton-c/src/codec/codec.c e8750fe
proton-c/src/codec/decoder.c dbbb13f
proton-c/src/engine/engine-internal.h 2f0cc56
proton-c/src/engine/engine.c 67cc882
proton-c/src/object/list.c 14231f6
proton-c/src/object/map.c c969d24
proton-c/src/parser.c 93b6da4
proton-c/src/scanner.c ef54db4
proton-c/src/transport/transport.c e72875b
Diff: https://reviews.apache.org/r/35016/diff/
Testing
-------
It still compiles, and all unit tests still work.
Thanks,
michael goulish