You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andres de la Peña (Jira)" <ji...@apache.org> on 2022/02/02 16:04:00 UTC
[jira] [Comment Edited] (CASSANDRA-17341) Merge guardrails and track warnings configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-17341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485905#comment-17485905 ]
Andres de la Peña edited comment on CASSANDRA-17341 at 2/2/22, 4:03 PM:
------------------------------------------------------------------------
Here is the patch merging configurations that was initially proposed in CASSANDRA-17148:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1434]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1281/workflows/300f498b-7f93-4b20-ae8f-2e9d1709ffbc] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1281/workflows/54333f81-e222-46f8-b76e-c51fa41d8390]|
As it was mentioned in the original ticket, the patch only changes configuration and JMX methods, which is the minimum that we would need before making a release so we don't need to deprecate any current properties in the near future. The changes don't go beyond this, so nothing in track_warnings is extending the {{Guardrail}} class and, conversely, nothing in {{Guardrail}} and its extending classes is changed.
CC [~dcapwell]
was (Author: adelapena):
Here is the patch merging configurations that was initially proposed in CASSANDRA-17148:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1434]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1281/workflows/300f498b-7f93-4b20-ae8f-2e9d1709ffbc] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1281/workflows/54333f81-e222-46f8-b76e-c51fa41d8390]|
As it was mentioned in the original ticket, the patch only changes configuration and JMX methods, which is the minimum that we would need before making a release so we don't need to deprecate any current properties in the near future. The changes don't go beyond this, so nothing in track_warnings is extending the {{Guardrail}} class and, conversely, nothing in {{Guardrail}} and its extending classes is changed.
> Merge guardrails and track warnings configurations
> --------------------------------------------------
>
> Key: CASSANDRA-17341
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17341
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Guardrails, Local/Config
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
>
> As discussed in CASSANDRA-17148, a first step for the integration between guardrails and track warnings is merging their configurations, which are almost identical. This ticket would cover merging their config sections in {{cassandra.yaml}} and their corresponding JMX getters and setters. A tighter integration between the internals of both features wouldn't be part of this ticket, but of either CASSANDRA-17148 or a new subtask of it.
> Neither guardrails nor track warnings have included in any release, so it would be desirable to do this before releasing 4.1 so we don't have to deprecate properties.
> There's an ongoing discussion about refactoring {{cassandra.yaml}} spread across CASSANDRA-17292, CASSANDRA-17188 and CASSANDRA-17212. I understand that any change affecting the config for guardrails also affects the config track warnings, because they are almost identical. Thus, I think that merging both config sections would ease any refactoring plan that is agreed on that discussion.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org