You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (Created) (JIRA)" <ji...@apache.org> on 2011/12/05 14:31:39 UTC
[jira] [Created] (JCR-3170) Precompile JavaCC parsers in
jackrabbit-spi-commons
Precompile JavaCC parsers in jackrabbit-spi-commons
---------------------------------------------------
Key: JCR-3170
URL: https://issues.apache.org/jira/browse/JCR-3170
Project: Jackrabbit Content Repository
Issue Type: Improvement
Components: jackrabbit-spi-commons
Reporter: Jukka Zitting
Assignee: Jukka Zitting
Priority: Minor
The JavaCC-generated Java source files in jackrabbit-spi-commons require special configuration when importing Jackrabbit sources to an IDE like Eclipse. To make IDE integration smoother it would be nice if precompiled copies of the Java files existed the src/main/java folder.
Precompiling the sources would also allow us to avoid the JavaCC processing step during each Jackrabbit build. Instead we could have a separate profile for explicitly recompiling the JavaCC sources when they have been modified. In the past three years that has happened only once (JCR-952), so I think a bit of extra complexity there is justified by the simplification we can achieve in normal builds and IDE integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3170) Precompile JavaCC parsers in
jackrabbit-spi-commons
Posted by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163517#comment-13163517 ]
Jukka Zitting commented on JCR-3170:
------------------------------------
So far I haven't figured out a way to make Eclipse and other IDEs pick up the generated sources automatically during an import. Until we have such a patch I think having the precompiled sources in svn under src/main/java is the best solution here.
PS. For future reference: When changing the JavaCC sources, use "mvn clean install -Pjavacc" in jackrabbit-spi-commons and commit the updated files.
> Precompile JavaCC parsers in jackrabbit-spi-commons
> ---------------------------------------------------
>
> Key: JCR-3170
> URL: https://issues.apache.org/jira/browse/JCR-3170
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-spi-commons
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Labels: javacc
> Fix For: 2.3.5
>
>
> The JavaCC-generated Java source files in jackrabbit-spi-commons require special configuration when importing Jackrabbit sources to an IDE like Eclipse. To make IDE integration smoother it would be nice if precompiled copies of the Java files existed the src/main/java folder.
> Precompiling the sources would also allow us to avoid the JavaCC processing step during each Jackrabbit build. Instead we could have a separate profile for explicitly recompiling the JavaCC sources when they have been modified. In the past three years that has happened only once (JCR-952), so I think a bit of extra complexity there is justified by the simplification we can achieve in normal builds and IDE integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3170) Precompile JavaCC parsers in
jackrabbit-spi-commons
Posted by "Jukka Zitting (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-3170.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.3.5
Done in revision 1210476.
> Precompile JavaCC parsers in jackrabbit-spi-commons
> ---------------------------------------------------
>
> Key: JCR-3170
> URL: https://issues.apache.org/jira/browse/JCR-3170
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-spi-commons
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Labels: javacc
> Fix For: 2.3.5
>
>
> The JavaCC-generated Java source files in jackrabbit-spi-commons require special configuration when importing Jackrabbit sources to an IDE like Eclipse. To make IDE integration smoother it would be nice if precompiled copies of the Java files existed the src/main/java folder.
> Precompiling the sources would also allow us to avoid the JavaCC processing step during each Jackrabbit build. Instead we could have a separate profile for explicitly recompiling the JavaCC sources when they have been modified. In the past three years that has happened only once (JCR-952), so I think a bit of extra complexity there is justified by the simplification we can achieve in normal builds and IDE integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3170) Precompile JavaCC parsers in
jackrabbit-spi-commons
Posted by "Michael Dürig (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163529#comment-13163529 ]
Michael Dürig commented on JCR-3170:
------------------------------------
> PS. For future reference: When changing the JavaCC sources, use "mvn clean install -Pjavacc" in jackrabbit-spi-commons and commit the updated files.
I'm almost sure this will backfire since people will forget about this. At the very least we should put this note into the headers of all the JavaCC source files.
However, is it really worth to trade correctness for convenience here? I feel the IDE pain too. In fact I felt it for the past couple of years. Why the sudden hurry now?
> Precompile JavaCC parsers in jackrabbit-spi-commons
> ---------------------------------------------------
>
> Key: JCR-3170
> URL: https://issues.apache.org/jira/browse/JCR-3170
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-spi-commons
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Labels: javacc
> Fix For: 2.3.5
>
>
> The JavaCC-generated Java source files in jackrabbit-spi-commons require special configuration when importing Jackrabbit sources to an IDE like Eclipse. To make IDE integration smoother it would be nice if precompiled copies of the Java files existed the src/main/java folder.
> Precompiling the sources would also allow us to avoid the JavaCC processing step during each Jackrabbit build. Instead we could have a separate profile for explicitly recompiling the JavaCC sources when they have been modified. In the past three years that has happened only once (JCR-952), so I think a bit of extra complexity there is justified by the simplification we can achieve in normal builds and IDE integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3170) Precompile JavaCC parsers in
jackrabbit-spi-commons
Posted by "Felix Meschberger (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163107#comment-13163107 ]
Felix Meschberger commented on JCR-3170:
----------------------------------------
Sorry for being late. But I don't think, that I really like this ...
If you want to integrate this you can have an Maven Eclipse plugin setup to have the JavaCC process run on demand. Checking in generated code as primary source does not feel right.
> Precompile JavaCC parsers in jackrabbit-spi-commons
> ---------------------------------------------------
>
> Key: JCR-3170
> URL: https://issues.apache.org/jira/browse/JCR-3170
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-spi-commons
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Labels: javacc
> Fix For: 2.3.5
>
>
> The JavaCC-generated Java source files in jackrabbit-spi-commons require special configuration when importing Jackrabbit sources to an IDE like Eclipse. To make IDE integration smoother it would be nice if precompiled copies of the Java files existed the src/main/java folder.
> Precompiling the sources would also allow us to avoid the JavaCC processing step during each Jackrabbit build. Instead we could have a separate profile for explicitly recompiling the JavaCC sources when they have been modified. In the past three years that has happened only once (JCR-952), so I think a bit of extra complexity there is justified by the simplification we can achieve in normal builds and IDE integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3170) Precompile JavaCC parsers in
jackrabbit-spi-commons
Posted by "Claus Köll (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162806#comment-13162806 ]
Claus Köll commented on JCR-3170:
---------------------------------
+1 from me :-)
> Precompile JavaCC parsers in jackrabbit-spi-commons
> ---------------------------------------------------
>
> Key: JCR-3170
> URL: https://issues.apache.org/jira/browse/JCR-3170
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-spi-commons
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Labels: javacc
>
> The JavaCC-generated Java source files in jackrabbit-spi-commons require special configuration when importing Jackrabbit sources to an IDE like Eclipse. To make IDE integration smoother it would be nice if precompiled copies of the Java files existed the src/main/java folder.
> Precompiling the sources would also allow us to avoid the JavaCC processing step during each Jackrabbit build. Instead we could have a separate profile for explicitly recompiling the JavaCC sources when they have been modified. In the past three years that has happened only once (JCR-952), so I think a bit of extra complexity there is justified by the simplification we can achieve in normal builds and IDE integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3170) Precompile JavaCC parsers in
jackrabbit-spi-commons
Posted by "Thomas Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163429#comment-13163429 ]
Thomas Mueller commented on JCR-3170:
-------------------------------------
In this case, checking in the generated code probably simplifies a lot (anyway I hope we don't need JavaCC in the future).
Felix, do you have a list of concrete disadvantages? If not that's OK.
> Precompile JavaCC parsers in jackrabbit-spi-commons
> ---------------------------------------------------
>
> Key: JCR-3170
> URL: https://issues.apache.org/jira/browse/JCR-3170
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-spi-commons
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Labels: javacc
> Fix For: 2.3.5
>
>
> The JavaCC-generated Java source files in jackrabbit-spi-commons require special configuration when importing Jackrabbit sources to an IDE like Eclipse. To make IDE integration smoother it would be nice if precompiled copies of the Java files existed the src/main/java folder.
> Precompiling the sources would also allow us to avoid the JavaCC processing step during each Jackrabbit build. Instead we could have a separate profile for explicitly recompiling the JavaCC sources when they have been modified. In the past three years that has happened only once (JCR-952), so I think a bit of extra complexity there is justified by the simplification we can achieve in normal builds and IDE integration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira