You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by peedeeX21 <gi...@git.apache.org> on 2015/06/05 10:43:04 UTC
[GitHub] flink pull request: Added member currentSplit for FileInputFormat....
GitHub user peedeeX21 opened a pull request:
https://github.com/apache/flink/pull/791
Added member currentSplit for FileInputFormat.java
According to [this stackoverflow discussion] (http://stackoverflow.com/questions/30599616/create-objects-from-input-files-in-apache-flink/30600148?noredirect=1#comment49358891_30600148) with
@rmetzger the attribute currentSplit is now accessible through FileInputFormat. It provides the split that this parallel instance must consume.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peedeeX21/flink feature_fileinputformat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/791.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #791
----
commit be8bd1cb71d0f5d82a2003e1b354e9db6591889c
Author: Peter Schrott <pe...@gmail.com>
Date: 2015-06-05T08:37:26Z
[flink-core] Added the member currentSplit to FileInputFormat. This member contains the split that this parallel instance must consume.
commit 41e7f88c64ed3e0101958556c7bf4bdb7991f288
Author: Peter Schrott <pe...@gmail.com>
Date: 2015-06-05T08:39:15Z
Merge branch 'master' of github.com:apache/flink into feature_fileinputformat
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Added member currentSplit for FileInputFormat....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/791
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Added member currentSplit for FileInputFormat....
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/791#issuecomment-109370682
+1 , good addition
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Added member currentSplit for FileInputFormat....
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/791#issuecomment-109802171
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Added member currentSplit for FileInputFormat....
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/791#issuecomment-109205245
Thank you for the contribution.
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Added member currentSplit for FileInputFormat....
Posted by peedeeX21 <gi...@git.apache.org>.
Github user peedeeX21 commented on the pull request:
https://github.com/apache/flink/pull/791#issuecomment-109249506
Travis fails executing this test: `KafkaITCase.testPersistentSourceWithOffsetUpdates`. Unfortunately I have no idea what the problem is. I am not even sure if this is related to my commit.
Can someone have a look at it? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Added member currentSplit for FileInputFormat....
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/791#issuecomment-109296590
Hi, this `KafkaITCase` is known to be unstable and I have actually a fix that disables the test for now. Since only 1 out of 5 jobs failed, your change doesn't break anything and is still good to merge (in my opinion)
I would like to get confirmation from at least one other committer before merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Added member currentSplit for FileInputFormat....
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/791#issuecomment-109802550
... merged (github mirror broken?!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---