You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "michael-o (via GitHub)" <gi...@apache.org> on 2023/12/29 09:32:28 UTC
[PR] Use @Component only [maven-dependency-plugin]
michael-o opened a new pull request, #360:
URL: https://github.com/apache/maven-dependency-plugin/pull/360
This should depict the failing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use @Component only [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #360:
URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871964145
@michael-o @cstamas please look at my commit ... I fix one test by adding mock MavenProject and MavenSession as component in test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use @Component only [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #360:
URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871946562
Unit tests still fail for me ....
But executing ITs are ok ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MDEP-894 Use `@Component` only [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #360:
URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-2015687301
rebased and use latest released versions of m-plugin-tools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use @Component only [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #360:
URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1872079561
Unit test pass.
Site build due to parameters list can be null 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use @Component only [maven-dependency-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #360:
URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1872256364
@slawekjaranowski This is fantastic work, **thank you**. Your change must go with the upgrade of MPLUGIN with every modified plugin as well as this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use @Component only [maven-dependency-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #360:
URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871955789
> Unit tests still fail for me .... But executing ITs are ok ...
Yes, that's the point. A misconfig or dep is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MDEP-894] Use `@Component` only - fix tests [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #360:
URL: https://github.com/apache/maven-dependency-plugin/pull/360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org