You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "xdelox (via GitHub)" <gi...@apache.org> on 2024/09/16 15:59:17 UTC
[PR] Fixes #4321 - Cannot delete folders with Azure Multiaccount authentication (hop)
xdelox opened a new pull request, #4323:
URL: https://github.com/apache/hop/pull/4323
Fixes #4321
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes #4321 - Cannot delete folders with Azure Multiaccount authentication (hop)
Posted by "xdelox (via GitHub)" <gi...@apache.org>.
xdelox commented on code in PR #4323:
URL: https://github.com/apache/hop/pull/4323#discussion_r1761431786
##########
integration-tests/azure/main-0008-create-fill-delete-folder.hwf:
##########
Review Comment:
I've added this IT for the sake of testing locally, I knew these ITs are temporarily disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes #4321 - Cannot delete folders with Azure Multiaccount authentication (hop)
Posted by "xdelox (via GitHub)" <gi...@apache.org>.
xdelox commented on code in PR #4323:
URL: https://github.com/apache/hop/pull/4323#discussion_r1761434798
##########
plugins/actions/deletefolders/src/main/java/org/apache/hop/workflow/actions/deletefolders/ActionDeleteFolders.java:
##########
Review Comment:
with this second argument, this override of the method is able to resolve custom namespaces for picking the right Filesystem provider.
I see @hansva used it all around, instead of the previous version. However I wonder if we should consider to deprecate the old method, which looks the same, for the rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes #4321 - Cannot delete folders with Azure Multiaccount authentication (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on code in PR #4323:
URL: https://github.com/apache/hop/pull/4323#discussion_r1761438547
##########
plugins/actions/deletefolders/src/main/java/org/apache/hop/workflow/actions/deletefolders/ActionDeleteFolders.java:
##########
Review Comment:
There are spots where that's not possible because of chicken-egg for example loading the project and metadata can also be done via VFS but can't use the custom locations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes #4321 - Cannot delete folders with Azure Multiaccount authentication (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva merged PR #4323:
URL: https://github.com/apache/hop/pull/4323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org