You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Craig Russell (JIRA)" <ji...@codehaus.org> on 2008/11/07 20:25:13 UTC
[jira] Created: (MENFORCER-56) NPE if contains
an unset variable
NPE if <requireFilesExist> contains an unset variable
-----------------------------------------------------
Key: MENFORCER-56
URL: http://jira.codehaus.org/browse/MENFORCER-56
Project: Maven 2.x Enforcer Plugin
Issue Type: Bug
Reporter: Craig Russell
Assignee: Brian Fox
With this snippet of metadata:
<requireProperty>
<property>ndbj.jnilib2</property>
<message>"You must have a ndbj.jnilib2!"</message>
</requireProperty>
<requireFilesExist>
<files>
<file>${ndbj.jnilib2}</file>
</files>
</requireFilesExist>
the variable ndbj.jnilib2 doesn't exist and results in:
java.lang.NullPointerException
at org.apache.maven.plugins.enforcer.RequireFilesExist.checkFile(RequireFilesExist.java:38)
at org.apache.maven.plugins.enforcer.AbstractRequireFiles.execute(AbstractRequireFiles.java:71)
at org.apache.maven.plugins.enforcer.EnforceMojo.execute(EnforceMojo.java:185)
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:272)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MENFORCER-56) NPE if contains
an unset variable
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter closed MENFORCER-56.
---------------------------------
Assignee: Brett Porter (was: Brian Fox)
Resolution: Fixed
also needed to adjust the error message. Added a test to confirm.
> NPE if <requireFilesExist> contains an unset variable
> -----------------------------------------------------
>
> Key: MENFORCER-56
> URL: http://jira.codehaus.org/browse/MENFORCER-56
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
> Reporter: Craig Russell
> Assignee: Brett Porter
> Fix For: 1.0
>
> Attachments: menforcer-56.patch
>
>
> With this snippet of metadata:
> <requireProperty>
> <property>ndbj.jnilib2</property>
> <message>"You must have a ndbj.jnilib2!"</message>
> </requireProperty>
> <requireFilesExist>
> <files>
> <file>${ndbj.jnilib2}</file>
> </files>
> </requireFilesExist>
> the variable ndbj.jnilib2 doesn't exist and results in:
> java.lang.NullPointerException
> at org.apache.maven.plugins.enforcer.RequireFilesExist.checkFile(RequireFilesExist.java:38)
> at org.apache.maven.plugins.enforcer.AbstractRequireFiles.execute(AbstractRequireFiles.java:71)
> at org.apache.maven.plugins.enforcer.EnforceMojo.execute(EnforceMojo.java:185)
> at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:272)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:585)
> at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MENFORCER-56) NPE if contains
an unset variable
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MENFORCER-56:
----------------------------------
Fix Version/s: 1.0
> NPE if <requireFilesExist> contains an unset variable
> -----------------------------------------------------
>
> Key: MENFORCER-56
> URL: http://jira.codehaus.org/browse/MENFORCER-56
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
> Reporter: Craig Russell
> Assignee: Brian Fox
> Fix For: 1.0
>
> Attachments: menforcer-56.patch
>
>
> With this snippet of metadata:
> <requireProperty>
> <property>ndbj.jnilib2</property>
> <message>"You must have a ndbj.jnilib2!"</message>
> </requireProperty>
> <requireFilesExist>
> <files>
> <file>${ndbj.jnilib2}</file>
> </files>
> </requireFilesExist>
> the variable ndbj.jnilib2 doesn't exist and results in:
> java.lang.NullPointerException
> at org.apache.maven.plugins.enforcer.RequireFilesExist.checkFile(RequireFilesExist.java:38)
> at org.apache.maven.plugins.enforcer.AbstractRequireFiles.execute(AbstractRequireFiles.java:71)
> at org.apache.maven.plugins.enforcer.EnforceMojo.execute(EnforceMojo.java:185)
> at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:272)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:585)
> at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MENFORCER-56) NPE if contains
an unset variable
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MENFORCER-56:
----------------------------------
Component/s: Standard Rules
> NPE if <requireFilesExist> contains an unset variable
> -----------------------------------------------------
>
> Key: MENFORCER-56
> URL: http://jira.codehaus.org/browse/MENFORCER-56
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
> Reporter: Craig Russell
> Assignee: Brian Fox
> Attachments: menforcer-56.patch
>
>
> With this snippet of metadata:
> <requireProperty>
> <property>ndbj.jnilib2</property>
> <message>"You must have a ndbj.jnilib2!"</message>
> </requireProperty>
> <requireFilesExist>
> <files>
> <file>${ndbj.jnilib2}</file>
> </files>
> </requireFilesExist>
> the variable ndbj.jnilib2 doesn't exist and results in:
> java.lang.NullPointerException
> at org.apache.maven.plugins.enforcer.RequireFilesExist.checkFile(RequireFilesExist.java:38)
> at org.apache.maven.plugins.enforcer.AbstractRequireFiles.execute(AbstractRequireFiles.java:71)
> at org.apache.maven.plugins.enforcer.EnforceMojo.execute(EnforceMojo.java:185)
> at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:272)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:585)
> at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MENFORCER-56) NPE if contains
an unset variable
Posted by "Craig Russell (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Russell updated MENFORCER-56:
-----------------------------------
Attachment: menforcer-56.patch
This might be a reasonable patch or you might want to put the null check in the abstract superclass.
> NPE if <requireFilesExist> contains an unset variable
> -----------------------------------------------------
>
> Key: MENFORCER-56
> URL: http://jira.codehaus.org/browse/MENFORCER-56
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Bug
> Reporter: Craig Russell
> Assignee: Brian Fox
> Attachments: menforcer-56.patch
>
>
> With this snippet of metadata:
> <requireProperty>
> <property>ndbj.jnilib2</property>
> <message>"You must have a ndbj.jnilib2!"</message>
> </requireProperty>
> <requireFilesExist>
> <files>
> <file>${ndbj.jnilib2}</file>
> </files>
> </requireFilesExist>
> the variable ndbj.jnilib2 doesn't exist and results in:
> java.lang.NullPointerException
> at org.apache.maven.plugins.enforcer.RequireFilesExist.checkFile(RequireFilesExist.java:38)
> at org.apache.maven.plugins.enforcer.AbstractRequireFiles.execute(AbstractRequireFiles.java:71)
> at org.apache.maven.plugins.enforcer.EnforceMojo.execute(EnforceMojo.java:185)
> at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
> at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:272)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:585)
> at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
> at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
> at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira