You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nicolás Lichtmaier <ni...@reloco.com.ar> on 2004/04/03 12:26:15 UTC
So? How do we include this?
#include <svn_private_config.h>
or
#include "svn_private_config.h"
(And ok, after the other headers, even if I don't like it =) )
I have a patch to post! =)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: So? How do we include this?
Posted by Ben Reser <be...@reser.org>.
On Mon, Apr 05, 2004 at 08:27:39AM -0500, kfogel@collab.net wrote:
> But note
>
> http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=61867
>
> for a possible ghudson-motivated change to this convention. :-)
>
> Paint that bikeshed,
> Paint it good,
> They're sprouting up all over
> The neighborhood...,
Just to chime in here. I agree with ghudson that we should be using <>
unless we really need "". But I don't feel like the time to fix this is
worth the time to go looking for the cases. So my vote is to just keep
on using the convention. Like Karl says this is bikeshed. If someone
can come up to a real harm of using "" that is creating problems for us
then I could be convinced otherwise.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: So? How do we include this?
Posted by kf...@collab.net.
Branko Čibej <br...@xbc.nu> writes:
> Nicolás Lichtmaier wrote:
> > #include <svn_private_config.h>
> >
> > or
> >
> > #include "svn_private_config.h"
>
> Headers that are part of Subversion should be included with "", those
> that belong to external libraries or the system should use <>.
But note
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=61867
for a possible ghudson-motivated change to this convention. :-)
Paint that bikeshed,
Paint it good,
They're sprouting up all over
The neighborhood...,
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: So? How do we include this?
Posted by Branko Čibej <br...@xbc.nu>.
Nicolás Lichtmaier wrote:
> #include <svn_private_config.h>
>
> or
>
> #include "svn_private_config.h"
Headers that are part of Subversion should be included with "", those
that belong to external libraries or the system should use <>.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org