You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/24 05:54:44 UTC

[GitHub] [spark] viirya commented on a change in pull request #33989: [SPARK-36676][SQL][BUILD] Create shaded Hive module and upgrade Guava version to 30.1.1-jre

viirya commented on a change in pull request #33989:
URL: https://github.com/apache/spark/pull/33989#discussion_r715335263



##########
File path: assembly/pom.xml
##########
@@ -165,6 +169,13 @@
     <profile>
       <id>hive</id>
       <dependencies>
+        <!-- re-declare the dependency here so hive.deps.scope would take effect -->

Review comment:
       okay thanks for the update!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org