You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by resmo <gi...@git.apache.org> on 2015/05/13 10:09:17 UTC
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
GitHub user resmo opened a pull request:
https://github.com/apache/cloudstack/pull/249
ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an…
…d cleanup
Fixes API duplicate parameter in docs and makes it more clear.
Fixes a bunch of typos.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/resmo/cloudstack fix/cleanup_egress_firewallrules_api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #249
----
commit 556ebd9ce8197ebd3b3ef38bda6986050d38cd46
Author: Rene Moser <re...@apache.org>
Date: 2015-05-13T08:07:20Z
ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd and cleanup
Fixes API duplicate parameter in docs and makes it more clear.
Fixes a bunch of typos.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/249#issuecomment-103890479
@bhaisaab a good IDE helps indeed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by resmo <gi...@git.apache.org>.
Github user resmo closed the pull request at:
https://github.com/apache/cloudstack/pull/249
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by resmo <gi...@git.apache.org>.
GitHub user resmo reopened a pull request:
https://github.com/apache/cloudstack/pull/249
ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an…
…d cleanup
Fixes API duplicate parameter in docs and makes it more clear.
Fixes a bunch of typos.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/resmo/cloudstack fix/cleanup_egress_firewallrules_api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #249
----
commit 7991dd015e9dae9df91b8b8bf7eab63b04b02370
Author: Rene Moser <re...@apache.org>
Date: 2015-05-13T08:12:30Z
ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd and cleanup
Fixes API duplicate parameter in docs and makes it more clear.
Fixes a bunch of typos.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/249
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/249#issuecomment-103429103
@bhaisaab It's been a while since I coded JAVA, have no clue, why it is failing. May I ask you for a hint?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/249#issuecomment-103938699
Builds fine, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/249#issuecomment-101671523
@resmo can you check and fix the build issue? Travis is failing too while building.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by resmo <gi...@git.apache.org>.
Github user resmo closed the pull request at:
https://github.com/apache/cloudstack/pull/249
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/249#issuecomment-103934999
@resmo looks good to me, Travis is green too. Will merge tonight or tomorrow after some build tests. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/249#issuecomment-103431009
@resmo looks like an interface/type issue, see the error here: https://builds.apache.org/job/cloudstack-pull-requests/160/console I can help fix it next week, but if you've an IDE just fix the type and interface usage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...
Posted by resmo <gi...@git.apache.org>.
GitHub user resmo reopened a pull request:
https://github.com/apache/cloudstack/pull/249
ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an…
…d cleanup
Fixes API duplicate parameter in docs and makes it more clear.
Fixes a bunch of typos.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/resmo/cloudstack fix/cleanup_egress_firewallrules_api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #249
----
commit bcd0a2ce83e648593badde004133d06b7c86d7e7
Author: Rene Moser <re...@apache.org>
Date: 2015-05-19T14:10:58Z
ListFirewallEgressRulesCmd: add interfaces and minor cleanup
This commit does not implement new functionality:
* Fixes duplicate parameter in API docs.
* Fixes a bunch of typos.
* Add interfaces to make it easier for the FirewallService interface.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---