You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/06 14:19:18 UTC

[GitHub] [flink] rkhachatryan commented on pull request #11899: [FLINK-17342] enqueue savepoint requests in UC mode

rkhachatryan commented on pull request #11899:
URL: https://github.com/apache/flink/pull/11899#issuecomment-624677519


   Thanks for the feedback @pnowojski.
   
   I've updated the code, please take a look.
   
   Some changes not related directly to your comments:
   1. I realized that with a queue limit in place we don't have to drop requests anymore if there are too many pending checkpoints. Dropping can cause a delay (until timer fires next time) so I removed it.
   2. If queue is too big `decider` now drops the least significant queued request (instead of the new one). I replaced queue with a tree for that.
   3.  Increased test coverage for these and existing cases.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org