You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Michael Semb Wever (Jira)" <ji...@apache.org> on 2022/12/09 22:58:00 UTC
[jira] [Comment Edited] (CASSANDRA-17797) All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
[ https://issues.apache.org/jira/browse/CASSANDRA-17797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645509#comment-17645509 ]
Michael Semb Wever edited comment on CASSANDRA-17797 at 12/9/22 10:57 PM:
--------------------------------------------------------------------------
I like your work here [~mmuzaf].
1. agree.
2. despite not having the {{cassandra.}} prefix, they are for all intensive purposes very much about cassandra here. hence they are included.
3. this is intentional. it is a smell, but the alternatives (when i tried) were all worse. commenting/annotating them as test works for me (perfect is the enemy of good).
bq. system properties may affect lead to some performance issues due to the Hashtable
i'd be surprised if this occurs on any hot paths. code in those areas go through much stricter reviews. but open to suggestions if you find something simple and elegant.
was (Author: michaelsembwever):
I like your work here [~mmuzaf].
1. agree.
2. despite not having the {{cassandra.}} prefix, they are for all intensive purposes very much about cassandra here. hence they are included.
3. this is intentional. it is a smell, but the alternatives (when i tried) were all worse. commenting them as test works for me (perfect is the enemy of good).
bq. system properties may affect lead to some performance issues due to the Hashtable
i'd be surprised if this occurs on any hot paths. code in those areas go through much stricter reviews. but open to suggestions if you find something simple and elegant.
> All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17797
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17797
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Maxim Muzafarov
> Priority: Low
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Follow up ticket for CASSANDRA-15876 -
> "Always access system properties and environment variables via the new CassandraRelevantProperties and CassandraRelevantEnv classes"
> As part of that ticket we moved to the two new classes only properties/variables that were currently listed in System Properties Virtual Table.
> We have to move to those classes the rest of the properties around the code and start using those classes to access all of them.
> +Additional information for newcomers:+
> You might want to start by getting acquainted with CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might want to check what changes were done and how the first batch was transferred to this new framework as part of [CASSANDRA-15876|https://github.com/apache/cassandra/commit/7694c1d191531ac152db55e83bc0db6864a5441e]
> We are interested into the properties accessed currently through getProperties around the code.
> As part of CASSANDRA-15876 relevant unit tests were added (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure that all tests Cassandra pass and also to think about potential update of the mentioned test class.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org