[jira] [Commented] (CALCITE-2253) Fix matching predicate for JdbcProjectRule rule

["Volodymyr Vysotskyi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438407#comment-16438407 ] 

Volodymyr Vysotskyi commented on CALCITE-2253:
----------------------------------------------

I have created a pull request with the fix: https://github.com/apache/calcite/pull/664. Could someone please take a look?

> Fix matching predicate for JdbcProjectRule rule
> -----------------------------------------------
>
>                 Key: CALCITE-2253
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2253
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Julian Hyde
>            Priority: Major
>
> In CALCITE-2206 was prevented pushing windowed aggregates down for the {{SqlDialect}} s which do not support windowed functions.
> After these changes, {{JdbcProjectRule}} is matched *only* for the cases when {{SqlDialect}} supports windowed functions and project contains windowed functions:
> {code:java}
> return out.dialect.supportsWindowFunctions()
>     && !RexOver.containsOver(project.getProjects(), null);
> {code}
> It causes unit tests failures seen on the master.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)