You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/09/28 18:49:26 UTC
[GitHub] [trafficcontrol] jpappa200 opened a new pull request #6240: t3c setting mode 0600 for secure files
jpappa200 opened a new pull request #6240:
URL: https://github.com/apache/trafficcontrol/pull/6240
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
Closes: #6032
As described in the issue files designated secure will be written with 0600 permissions.
<!-- **^ Add meaningful description above** --><hr>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Control Cache Config (T3C, formerly ORT)
## What is the best way to verify this PR?
Build an rpm, install it on an admin_down or lab cache, queue updates and run t3c in apply mode.
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6240: t3c setting mode 0600 for secure files
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6240:
URL: https://github.com/apache/trafficcontrol/pull/6240#discussion_r746001676
##########
File path: cache-config/t3c-check-reload/README.md
##########
@@ -58,25 +59,14 @@ Possible return values are:
'' - no reload or restart is necessary.
-# OPTIONS
-
--c, --changed-config-paths=value
+# JSON Format
- comma-delimited list of the full paths of all files changed
- by t3c
+ {"changed_files":"<list of files>","installed_plugins":"<list of plugins>"}
+# OPTIONS
-h, --help
Print usage information and exit
--m, --run-mode=value
-
- [badass | report | revalidate | syncds] run mode, default is
- 'report' [report]
-
--p, --plugin-packages-installed=value
-
- comma-delimited list of ATS plugin packages which were
- installed by t3c
Review comment:
I can merge when conflicts are fixed - but quick question: is this gonna cause upgrade issues with like cron jobs or something? I don't see anything that would change cron jobs in the spec file or anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6240: t3c setting mode 0600 for secure files
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6240:
URL: https://github.com/apache/trafficcontrol/pull/6240#discussion_r746090071
##########
File path: cache-config/t3c-check-reload/README.md
##########
@@ -58,25 +59,14 @@ Possible return values are:
'' - no reload or restart is necessary.
-# OPTIONS
-
--c, --changed-config-paths=value
+# JSON Format
- comma-delimited list of the full paths of all files changed
- by t3c
+ {"changed_files":"<list of files>","installed_plugins":"<list of plugins>"}
+# OPTIONS
-h, --help
Print usage information and exit
--m, --run-mode=value
-
- [badass | report | revalidate | syncds] run mode, default is
- 'report' [report]
-
--p, --plugin-packages-installed=value
-
- comma-delimited list of ATS plugin packages which were
- installed by t3c
Review comment:
Alright, shame we don't support calling `t3c check-reload` by itself but that's nothing new - atstccfg was the same way, so if anyone's doing that it's on them, I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jpappa200 commented on a change in pull request #6240: t3c setting mode 0600 for secure files
Posted by GitBox <gi...@apache.org>.
jpappa200 commented on a change in pull request #6240:
URL: https://github.com/apache/trafficcontrol/pull/6240#discussion_r746086596
##########
File path: cache-config/t3c-check-reload/README.md
##########
@@ -58,25 +59,14 @@ Possible return values are:
'' - no reload or restart is necessary.
-# OPTIONS
-
--c, --changed-config-paths=value
+# JSON Format
- comma-delimited list of the full paths of all files changed
- by t3c
+ {"changed_files":"<list of files>","installed_plugins":"<list of plugins>"}
+# OPTIONS
-h, --help
Print usage information and exit
--m, --run-mode=value
-
- [badass | report | revalidate | syncds] run mode, default is
- 'report' [report]
-
--p, --plugin-packages-installed=value
-
- comma-delimited list of ATS plugin packages which were
- installed by t3c
Review comment:
Conflicts have been fixed it was just in the changelog. since t3c-check-reload is called inside of t3c-apply the cron job should not have to change. I remove --run-mode from the README.md since it was never used. The other 2 flags are replace by json input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #6240: t3c setting mode 0600 for secure files
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #6240:
URL: https://github.com/apache/trafficcontrol/pull/6240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org