[jira] [Comment Edited] (OAK-4018) Test failures after upgrading to JR 2.12.0

["Tomek Rękawek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147184#comment-15147184 ] 

Tomek Rękawek edited comment on OAK-4018 at 2/15/16 10:37 AM:
--------------------------------------------------------------

oak-upgrade modifies the {{jcr:mixinTypes}} property, by replacing all {{mix:simpleVersioninable}} with {{mix:versionable}} (as Oak doesn't support the first type of versionables) - it's done in the {{JackrabbitNodeState#createProperties()}} method.

However, after the JCR-2633, we have {{jcr:mixinTypes}} property exposed in the {{NodePropBundle#getPropertyEntries()}} collection. As a result, the original {{jcr:mixinTypes}} property overrides the one prepared by oak-upgrade. I think it can be easily fixed - first we should copy all properties from the bundle and then put the new {{jcr:mixinTypes}}.

Attached patch simply moves the properties-filling loop before the custom {{jcr:mixinTypes}} creation.


was (Author: tomek.rekawek):
oak-upgrade modifies the {{jcr:mixinTypes}} property, by replacing all {{mix:simpleVersioninable}} with {{mix:versionable}} (as Oak doesn't support the first type of versionables) - it's done in the {{JackrabbitNodeState#createProperties()}} method. However, after the JCR-2633, we have {{jcr:mixinTypes}} property exposed in the {{NodePropBundle#getPropertyEntries()}} collection. As a result, the original {{jcr:mixinTypes}} property overrides the one prepared by oak-upgrade. I think it can be easily fixed - first we should copy all properties from the bundle and then put the new {{jcr:mixinTypes}}.

Attached patch simply moves the properties-filling loop before the custom {{jcr:mixinTypes}} creation.

> Test failures after upgrading to JR 2.12.0
> ------------------------------------------
>
>                 Key: OAK-4018
>                 URL: https://issues.apache.org/jira/browse/OAK-4018
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: upgrade
>    Affects Versions: 1.3.15
>            Reporter: Davide Giannella
>            Assignee: Manfred Baedke
>            Priority: Blocker
>             Fix For: 1.3.16
>
>         Attachments: OAK-4018.patch
>
>
> After the upgrade to Jackrabbit 2.12.0 we have the following test failures:
> {noformat}
> Failed tests:  
> referencedOlderThanOrphaned(org.apache.jackrabbit.oak.upgrade.CopyVersionHistoryTest):
> No history found for /versionables/mix:simpleVersionable/old
>  
> copyAllVersions(org.apache.jackrabbit.oak.upgrade.CopyVersionHistoryTest):
> Node /versionables/mix:simpleVersionable/old should have mix:versionable
> mixin
>  
> onlyReferencedAfterDate(org.apache.jackrabbit.oak.upgrade.CopyVersionHistoryTest):
> No history found for /versionables/mix:simpleVersionable/young
>  
> onlyReferenced(org.apache.jackrabbit.oak.upgrade.CopyVersionHistoryTest): No
> history found for /versionables/mix:simpleVersionable/old
>  
> referencedSinceDate(org.apache.jackrabbit.oak.upgrade.CopyVersionHistoryTest):
> Node /versionables/mix:simpleVersionable/young should have
> mix:versionable mixin
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)