You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/04 05:08:16 UTC
[GitHub] [orc] yuokada opened a new pull request #737: Add the break label to PrintData.java
yuokada opened a new pull request #737:
URL: https://github.com/apache/orc/pull/737
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #737: ORC-839: Fix head command for batch reader
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-882620561
Thank you so much, @yuokada and @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on a change in pull request #737: ORC-728: Add the break label to PrintData.java
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #737:
URL: https://github.com/apache/orc/pull/737#discussion_r664692439
##########
File path: java/tools/src/java/org/apache/orc/tools/PrintData.java
##########
@@ -207,6 +207,7 @@ static void printJsonData(PrintStream printStream,
TypeDescription schema = reader.getSchema();
VectorizedRowBatch batch = schema.createRowBatch();
Integer counter = 0;
+ label:
Review comment:
Can we change the logic here avoiding labels?
Want to make sure readability here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #737: ORC-839: Add the break label to PrintData.java
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-881932442
Thank you for updating, @yuokada . If this is ready for review, could you convert your PR status?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] yuokada commented on pull request #737: ORC-839: Add the break label to PrintData.java
Posted by GitBox <gi...@apache.org>.
yuokada commented on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-876807604
@pgaref Thanks for your comment. I filed ORC-839.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #737: ORC-839: Fix head command for batch reader
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-882620561
Thank you so much, @yuokada , @pgaref , and @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #737: ORC-839: Add the break label to PrintData.java
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-881932442
Thank you for updating, @yuokada .
- If this is ready for review, could you convert your PR status?
- Please update the PR title because we don't use `break` in this AS-IS PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #737: ORC-839: Fix head command for batch reader
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-882620561
Thank you so much, @yuokada , @pgaref , and @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #737: ORC-839: Fix head command for batch reader
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-882620561
Thank you so much, @yuokada , @pgaref , and @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #737: ORC-839: Add the break label to PrintData.java
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-881932573
cc @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #737: ORC-728: Add the break label to PrintData.java
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-874892051
@yuokada thanks for the FIX!
ORC-728 is closed so we will need a new one -- can you please create one and update PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] yuokada commented on a change in pull request #737: ORC-839: Add the break label to PrintData.java
Posted by GitBox <gi...@apache.org>.
yuokada commented on a change in pull request #737:
URL: https://github.com/apache/orc/pull/737#discussion_r668340411
##########
File path: java/tools/src/java/org/apache/orc/tools/PrintData.java
##########
@@ -207,6 +207,7 @@ static void printJsonData(PrintStream printStream,
TypeDescription schema = reader.getSchema();
VectorizedRowBatch batch = schema.createRowBatch();
Integer counter = 0;
+ label:
Review comment:
@pgaref I will try to change (I changed the status of this to DRAFT). But, I think that the 1st code is the simplest way to fix this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] asfgit closed pull request #737: ORC-839: Fix head command for batch reader
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #737:
URL: https://github.com/apache/orc/pull/737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #737: ORC-839: Fix head command for batch reader
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-882150965
+1 LGTM
Merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #737: ORC-839: Fix head command for batch reader
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-882620561
Thank you so much, @yuokada and @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #737: ORC-839: Fix head command for batch reader
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #737:
URL: https://github.com/apache/orc/pull/737#issuecomment-882620561
Thank you so much, @yuokada and @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org