You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2017/11/06 21:40:55 UTC

[GitHub] spark pull request #17702: [SPARK-20408][SQL] Get the glob path in parallel ...

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17702#discussion_r149211599
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala ---
    @@ -246,6 +246,18 @@ class SparkHadoopUtil extends Logging {
         if (isGlobPath(pattern)) globPath(fs, pattern) else Seq(pattern)
       }
     
    +  def expandGlobPath(fs: FileSystem, pattern: Path): Seq[String] = {
    --- End diff --
    
    Please add unit tests for this method.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org