[GitHub] HyukjinKwon edited a comment on issue #23341: [SPARK-26081][SQL][FOLLOW-UP] Use foreach instead of misuse of map (for Unit)

[GitBox <gi...@apache.org>]

HyukjinKwon edited a comment on issue #23341: [SPARK-26081][SQL][FOLLOW-UP] Use foreach instead of misuse of map (for Unit)
URL: https://github.com/apache/spark/pull/23341#issuecomment-448150695
 
 
   I don't think currently it causes actual problem for now .. simply using `foreach` is preferred over `map` when the output from `map` is not used.
   
   Good practice is to call `map` only when the return is explicitly used. If `close()` returns `Boolean` in the future, it should return `Boolean` explicitly ...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org