You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/02/10 01:30:38 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #578: [MINOR] chore: skip java tests in kubernetes profile
kaijchen opened a new pull request, #578:
URL: https://github.com/apache/incubator-uniffle/pull/578
### What changes were proposed in this pull request?
1. Skip java tests in kubernetes profile.
2. Make operator test phase hornor `skipTests` property.
### Why are the changes needed?
Speed up `-Pkubernetes` in CI.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425100729
> > Seems like other module is still compiled . it is possible to run build-operator.sh and test-operator.sh directly. You can use `mvn package -P kubernetes -am -pl deploy/kubernetes ` to just build the operator package. And there's no need to skipTests here.
>
> We need other jars to run K8S integration tests, so we should compile them.
Currently, there's no jars needed to run K8S tests? Even if we enable integration tests, we may relies the rss-server images to run integration tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425126655
> > > We should use latest jars to produce image.
> >
> >
> > you mean `deploy/kubernetes/docker/Dockerfile`? I think it's not used in CI.
>
> Yes. why don't we use it in IT?
We just don't docker build this Dockerfile yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen merged pull request #578: [#580] chore: move deploy/kubernetes to a standalone workflow
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen merged PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425070052
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#578](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e455c46) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/b8d424d05562648c6e1e789e4614584cbad01a99?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8d424d) will **increase** coverage by `2.26%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #578 +/- ##
============================================
+ Coverage 60.85% 63.11% +2.26%
+ Complexity 1798 1797 -1
============================================
Files 213 199 -14
Lines 12385 10414 -1971
Branches 1051 1051
============================================
- Hits 7537 6573 -964
+ Misses 4439 3491 -948
+ Partials 409 350 -59
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/hadoop/mapreduce/task/reduce/RssFetcher.java](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3Rhc2svcmVkdWNlL1Jzc0ZldGNoZXIuamF2YQ==) | `90.76% <0.00%> (-1.54%)` | :arrow_down: |
| [...y/kubernetes/operator/pkg/webhook/inspector/rss.go](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3dlYmhvb2svaW5zcGVjdG9yL3Jzcy5nbw==) | | |
| [...tor/pkg/controller/sync/coordinator/coordinator.go](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXIvc3luYy9jb29yZGluYXRvci9jb29yZGluYXRvci5nbw==) | | |
| [deploy/kubernetes/operator/pkg/utils/util.go](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3V0aWxzL3V0aWwuZ28=) | | |
| [...pkg/controller/sync/shuffleserver/shuffleserver.go](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXIvc3luYy9zaHVmZmxlc2VydmVyL3NodWZmbGVzZXJ2ZXIuZ28=) | | |
| [deploy/kubernetes/operator/pkg/utils/certs.go](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3V0aWxzL2NlcnRzLmdv) | | |
| [deploy/kubernetes/operator/pkg/utils/rss.go](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3V0aWxzL3Jzcy5nbw==) | | |
| [...bernetes/operator/pkg/controller/controller/rss.go](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXIvY29udHJvbGxlci9yc3MuZ28=) | | |
| [...eploy/kubernetes/operator/pkg/utils/coordinator.go](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3V0aWxzL2Nvb3JkaW5hdG9yLmdv) | | |
| [deploy/kubernetes/operator/pkg/webhook/manager.go](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVwbG95L2t1YmVybmV0ZXMvb3BlcmF0b3IvcGtnL3dlYmhvb2svbWFuYWdlci5nbw==) | | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-uniffle/pull/578?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102270956
##########
deploy/kubernetes/pom.xml:
##########
@@ -53,6 +53,7 @@
</goals>
<configuration>
<executable>${basedir}/test-operator.sh</executable>
+ <skip>${skipTests}</skip>
Review Comment:
In kubernetes CI, `skipTests` is false,`skipUTs` and `skipITs` is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425144921
> @jerqi @advancedxy Let's just create a new CI workflow for deploy and k8s tests later. We can add `-DskipUTs -DskipITs` in the new workflow, and remove it from the `kubernetes` profile.
>
> The `parallel.yml` should be used just for integration with different compute engines.
fair point..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425082266
> Seems like other module is still compiled . it is possible to run build-operator.sh and test-operator.sh directly. You can use `mvn package -P kubernetes -am -pl deploy/kubernetes ` to just build the operator package. And there's no need to skipTests here.
We need other jars to run K8S integration tests, so we should compile them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425135154
> > > > > We should use latest jars to produce image.
> > > >
> > > >
> > > > you mean `deploy/kubernetes/docker/Dockerfile`? I think it's not used in CI.
> > >
> > >
> > > Yes. why don't we use it in IT?
> >
> >
> > We just don't docker build this Dockerfile yet.
>
> I mean that we will use it if we have IT tests.
Ah, yes. But I think in most cases, we will just reuse the already existed docker image or put the shuffler server docker image
build process parallel with rss-controller/rss-webhook build process.
When we start integration tests, the ci workflow will need some refactor work to support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425081366
Seems like other module is still compiled . it is possible to run build-operator.sh and test-operator.sh directly.
You can use `mvn package -P kubernetes -am -pl deploy/kubernetes ` to just build the operator package.
And there's no need to skipTests here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102275439
##########
deploy/kubernetes/pom.xml:
##########
@@ -53,6 +53,7 @@
</goals>
<configuration>
<executable>${basedir}/test-operator.sh</executable>
+ <skip>${skipTests}</skip>
Review Comment:
I just want to make sure no tests are run when user run:
```shell
mvn package -Pspark3 -Pkubernetes -DskipTests
```
but the `Makefile` should be updated to separate test with build.
Actually these properties should be removed:
```xml
<profile>
<id>kubernetes</id>
<properties>
<skipUTs>true</skipUTs>
<skipITs>true</skipITs>
</properties>
```
and we should run `-Pkubernetes` in CI with `-DskipUTs` and `-DskipITs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #578: [#580] chore: add a standalone workflow for deploy/kubernetes
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102419488
##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
with:
maven-args: package
reports-path: "**/target/surefire-reports/*.txt"
+
+ deploy:
+ uses: ./.github/workflows/deploy.yml
+ with:
+ maven-args: package
+ maven-options: -DskipUTs -DskipITs
Review Comment:
maybe you should use this trick to put maven options in the matrix sidehttps://stackoverflow.com/questions/66025220/paired-values-in-github-actions-matrix
##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
with:
maven-args: package
reports-path: "**/target/surefire-reports/*.txt"
+
+ deploy:
+ uses: ./.github/workflows/deploy.yml
+ with:
+ maven-args: package
+ maven-options: -DskipUTs -DskipITs
Review Comment:
maybe you should use this trick to put maven options in the matrix side. https://stackoverflow.com/questions/66025220/paired-values-in-github-actions-matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425082274
> Seems like other module is still compiled . it is possible to run build-operator.sh and test-operator.sh directly.
> You can use `mvn package -P kubernetes -am -pl deploy/kubernetes ` to just build the operator package.
> And there's no need to skipTests here.
This is just a workaround for current CI pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #578: [#580] chore: skip java tests in kubernetes profile
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102333188
##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
with:
maven-args: package
reports-path: "**/target/surefire-reports/*.txt"
+
+ deploy:
+ uses: ./.github/workflows/deploy.yml
+ with:
+ maven-args: package
+ maven-options: -DskipUTs -DskipITs
Review Comment:
Why do I add `K8S` profile?
Because we hope that we can use the maven to manage the whole project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #578: [#580] chore: add a standalone workflow for deploy/kubernetes
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102361371
##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
with:
maven-args: package
reports-path: "**/target/surefire-reports/*.txt"
+
+ deploy:
+ uses: ./.github/workflows/deploy.yml
+ with:
+ maven-args: package
+ maven-options: -DskipUTs -DskipITs
Review Comment:
There might be `deploy/YARN` in the future. Let's keep it as is now?
If you wish to not run it with maven, feel free to change it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #578: [#580] chore: skip java tests in kubernetes profile
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425258953
@jerqi @advancedxy I've added a standalone workflow. How do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #578: [#580] chore: add a standalone workflow for deploy/kubernetes
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102905379
##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
with:
maven-args: package
reports-path: "**/target/surefire-reports/*.txt"
+
+ deploy:
+ uses: ./.github/workflows/deploy.yml
+ with:
+ maven-args: package
+ maven-options: -DskipUTs -DskipITs
Review Comment:
I just want to do minimal changes to move k8s test out of `parallel.yml`.
And speed up k8s CI by skipping UT and IT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #578: [#580] chore: skip java tests in kubernetes profile
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102333188
##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
with:
maven-args: package
reports-path: "**/target/surefire-reports/*.txt"
+
+ deploy:
+ uses: ./.github/workflows/deploy.yml
+ with:
+ maven-args: package
+ maven-options: -DskipUTs -DskipITs
Review Comment:
Why do I add `K8S` profile?
Because we hope that we can use the maven to manage the whole project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102280294
##########
deploy/kubernetes/pom.xml:
##########
@@ -53,6 +53,7 @@
</goals>
<configuration>
<executable>${basedir}/test-operator.sh</executable>
+ <skip>${skipTests}</skip>
Review Comment:
> and we should run `-Pkubernetes` in CI with `-DskipUTs` and `-DskipITs`.
Let's add a new workflow in this PR after #579 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102272158
##########
pom.xml:
##########
@@ -79,6 +79,9 @@
<snappy-java.version>1.1.8.4</snappy-java.version>
<test.redirectToFile>true</test.redirectToFile>
<trimStackTrace>false</trimStackTrace>
+ <skipTests>false</skipTests>
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #578: [#580] chore: skip java tests in kubernetes profile
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425260305
It's ok for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #578: [#580] chore: add a standalone workflow for deploy/kubernetes
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102407636
##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
with:
maven-args: package
reports-path: "**/target/surefire-reports/*.txt"
+
+ deploy:
+ uses: ./.github/workflows/deploy.yml
+ with:
+ maven-args: package
+ maven-options: -DskipUTs -DskipITs
Review Comment:
> There might be `deploy/YARN` in the future. Let's keep it as is now? If you wish to not run it with maven, feel free to change it later.
I like the idea that we can simply call maven to build all the stuff. I am not intended to run without mvn.
I'am thinking about this case.
```
# for k8s
mvn -Pk8s -DskipUTs -DskipITs
# for yarn, it should be without -DskipUTs.
mvn -Pyarn
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425127245
> > > > We should use latest jars to produce image.
> > >
> > >
> > > you mean `deploy/kubernetes/docker/Dockerfile`? I think it's not used in CI.
> >
> >
> > Yes. why don't we use it in IT?
>
> We just don't docker build this Dockerfile yet.
I mean that we will use it if we have IT tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425115282
> > > Seems like other module is still compiled . it is possible to run build-operator.sh and test-operator.sh directly. You can use `mvn package -P kubernetes -am -pl deploy/kubernetes ` to just build the operator package. And there's no need to skipTests here.
> >
> >
> > We need other jars to run K8S integration tests, so we should compile them.
>
> Currently, there's no jars needed to run K8S tests? Even if we enable integration tests, we may relies the rss-server images to run integration tests?
We should use latest jars to produce image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102252679
##########
deploy/kubernetes/pom.xml:
##########
@@ -53,6 +53,7 @@
</goals>
<configuration>
<executable>${basedir}/test-operator.sh</executable>
+ <skip>${skipTests}</skip>
Review Comment:
this is not need.
./test-operator should be ran on ci.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #578: [#580] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102332091
##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
with:
maven-args: package
reports-path: "**/target/surefire-reports/*.txt"
+
+ deploy:
+ uses: ./.github/workflows/deploy.yml
+ with:
+ maven-args: package
+ maven-options: -DskipUTs -DskipITs
Review Comment:
for this case, I think it should be more related to the k8s profile?
For k8s, it doesn't need to run maven with uts..
however there could be other deploy options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #578: [#580] chore: add a standalone workflow for deploy/kubernetes
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102902723
##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
with:
maven-args: package
reports-path: "**/target/surefire-reports/*.txt"
+
+ deploy:
+ uses: ./.github/workflows/deploy.yml
+ with:
+ maven-args: package
+ maven-options: -DskipUTs -DskipITs
Review Comment:
> ```
> # for yarn, it should be without -DskipUTs.
> mvn -Pyarn
> ```
I don't want to support YARN in this PR.
YARN will be supported when it's introduced (probably never).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425123122
> We should use latest jars to produce image.
you mean `deploy/kubernetes/docker/Dockerfile`? I think it's not used in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425140706
@jerqi @advancedxy Let's just create a new CI workflow for deploy and k8s tests later.
The `parallel.yml` should be used just for integration with different compute engines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425148784
> > > > > > We should use latest jars to produce image.
> > > > >
> > > > >
> > > > > you mean `deploy/kubernetes/docker/Dockerfile`? I think it's not used in CI.
> > > >
> > > >
> > > > Yes. why don't we use it in IT?
> > >
> > >
> > > We just don't docker build this Dockerfile yet.
> >
> >
> > I mean that we will use it if we have IT tests.
>
> Ah, yes. But I think in most cases, we will just reuse the already existed docker image or put the shuffler server docker image build process parallel with rss-controller/rss-webhook build process.
>
> When we start integration tests, the ci workflow will need some refactor work to support it.
It's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102275439
##########
deploy/kubernetes/pom.xml:
##########
@@ -53,6 +53,7 @@
</goals>
<configuration>
<executable>${basedir}/test-operator.sh</executable>
+ <skip>${skipTests}</skip>
Review Comment:
I just want to make sure no tests are run when user run
```shell
mvn package -Pspark3 -Pkubernetes -DskipTests
```
Actually these properties should be removed:
```xml
<profile>
<id>kubernetes</id>
<properties>
<skipUTs>true</skipUTs>
<skipITs>true</skipITs>
</properties>
```
and we should run `-Pkubernetes` in CI with `-DskipUTs` and `-DskipITs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102275439
##########
deploy/kubernetes/pom.xml:
##########
@@ -53,6 +53,7 @@
</goals>
<configuration>
<executable>${basedir}/test-operator.sh</executable>
+ <skip>${skipTests}</skip>
Review Comment:
I just want to make sure no tests are run when user run
```
mvn package -Pspark3 -Pkubernetes -DskipTests
```
Actually these properties should be removed:
```
<profile>
<id>kubernetes</id>
<properties>
<skipUTs>true</skipUTs>
<skipITs>true</skipITs>
</properties>
```
and we should run `-Pkubernetes` in CI with `-DskipUTs` and `-DskipITs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #578: [#580] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425263875
> @jerqi @advancedxy I've added a standalone workflow. How do you think?
Sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #578: [#580] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102332259
##########
.github/workflows/build.yml:
##########
@@ -64,3 +64,9 @@ jobs:
with:
maven-args: package
reports-path: "**/target/surefire-reports/*.txt"
+
+ deploy:
+ uses: ./.github/workflows/deploy.yml
+ with:
+ maven-args: package
+ maven-options: -DskipUTs -DskipITs
Review Comment:
Unless you call it k8s_deploy.yml ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425081955
Anyway, many thanks for the work. I was thought about it a while ago.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1425124815
> > We should use latest jars to produce image.
>
> you mean `deploy/kubernetes/docker/Dockerfile`? I think it's not used in CI.
Yes. why don't we use it in IT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102252893
##########
pom.xml:
##########
@@ -79,6 +79,9 @@
<snappy-java.version>1.1.8.4</snappy-java.version>
<test.redirectToFile>true</test.redirectToFile>
<trimStackTrace>false</trimStackTrace>
+ <skipTests>false</skipTests>
Review Comment:
let's just remove this property. I think it brings some confusion...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #578: [MINOR] chore: skip java tests in kubernetes profile
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#discussion_r1102270956
##########
deploy/kubernetes/pom.xml:
##########
@@ -53,6 +53,7 @@
</goals>
<configuration>
<executable>${basedir}/test-operator.sh</executable>
+ <skip>${skipTests}</skip>
Review Comment:
In CI, `skipTests` is false,`skipUTs` and `skipITs` is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #578: [#580] chore: move deploy/kubernetes to a standalone workflow
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #578:
URL: https://github.com/apache/incubator-uniffle/pull/578#issuecomment-1427535416
Thanks @advancedxy and @jerqi for the discussion and review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org