You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/19 06:11:46 UTC

[GitHub] [shardingsphere] yanyzy opened a new pull request #5682: Support spring namespace for shadow rule

yanyzy opened a new pull request #5682:
URL: https://github.com/apache/shardingsphere/pull/5682


   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter commented on pull request #5682: Support spring namespace for shadow rule

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5682:
URL: https://github.com/apache/shardingsphere/pull/5682#issuecomment-630613780


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=h1) Report
   > Merging [#5682](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/82929d963de7ff771e83970d03f9d741e87b3ad9&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5682/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5682      +/-   ##
   ============================================
   + Coverage     55.66%   55.69%   +0.02%     
     Complexity      430      430              
   ============================================
     Files          1137     1138       +1     
     Lines         20207    20220      +13     
     Branches       3665     3667       +2     
   ============================================
   + Hits          11249    11262      +13     
     Misses         8286     8286              
     Partials        672      672              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...mespace/parser/ShadowRuleBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/5682/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtY29yZS1zcHJpbmctbmFtZXNwYWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kcml2ZXIvc3ByaW5nL25hbWVzcGFjZS9wYXJzZXIvU2hhZG93UnVsZUJlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...parser/ShardingDataSourceBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/5682/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtY29yZS1zcHJpbmctbmFtZXNwYWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kcml2ZXIvc3ByaW5nL25hbWVzcGFjZS9wYXJzZXIvU2hhcmRpbmdEYXRhU291cmNlQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `98.21% <100.00%> (+0.04%)` | `1.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=footer). Last update [82929d9...03229a7](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu merged pull request #5682: Support spring namespace for shadow rule

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5682:
URL: https://github.com/apache/shardingsphere/pull/5682


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5682: Support spring namespace for shadow rule

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5682:
URL: https://github.com/apache/shardingsphere/pull/5682#issuecomment-630613780


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=h1) Report
   > Merging [#5682](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6b63077cebb55ad2b03373b0d80999465161d025&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5682/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5682      +/-   ##
   ============================================
   - Coverage     53.82%   53.79%   -0.04%     
     Complexity      428      428              
   ============================================
     Files          1150     1152       +2     
     Lines         20249    20261      +12     
     Branches       3660     3661       +1     
   ============================================
     Hits          10900    10900              
   - Misses         8686     8698      +12     
     Partials        663      663              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../namespace/handler/ShadowRuleNamespaceHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/5682/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1zcHJpbmcvc2hhcmRpbmdzcGhlcmUtc2hhZG93LXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYWRvdy9zcHJpbmcvbmFtZXNwYWNlL2hhbmRsZXIvU2hhZG93UnVsZU5hbWVzcGFjZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...mespace/parser/ShadowRuleBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/5682/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1zcHJpbmcvc2hhcmRpbmdzcGhlcmUtc2hhZG93LXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYWRvdy9zcHJpbmcvbmFtZXNwYWNlL3BhcnNlci9TaGFkb3dSdWxlQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=footer). Last update [6b63077...e141e1d](https://codecov.io/gh/apache/shardingsphere/pull/5682?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org