You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@xerces.apache.org by "Perry A. Caro" <ca...@Adobe.COM> on 2001/01/17 20:29:34 UTC
Re: cvs commit: xml-xerces/c/src/dom NodeImpl.cpp NodeImpl.hpp
I was suprised by the change noticed included below. Does this mean
userData on any node is no longer supported? We're using that field for
user data.
lehors@apache.org wrote:
>
> lehors 01/01/17 09:25:55
>
> Modified: c/src/dom NodeImpl.cpp NodeImpl.hpp
> Log:
> removed unused field that was left over
>
> Revision Changes Path
> 1.31 +1 -3 xml-xerces/c/src/dom/NodeImpl.cpp
>
> Index: NodeImpl.cpp
> ===================================================================
> RCS file: /home/cvs/xml-xerces/c/src/dom/NodeImpl.cpp,v
> retrieving revision 1.30
> retrieving revision 1.31
> diff -u -r1.30 -r1.31
> --- NodeImpl.cpp 2000/08/17 22:47:10 1.30
> +++ NodeImpl.cpp 2001/01/17 17:25:53 1.31
> @@ -55,7 +55,7 @@
> */
>
> /*
> - * $Id: NodeImpl.cpp,v 1.30 2000/08/17 22:47:10 lehors Exp $
> + * $Id: NodeImpl.cpp,v 1.31 2001/01/17 17:25:53 lehors Exp $
> */
>
> // This class doesn't support having any children, and implements the behavior
> @@ -93,7 +93,6 @@
>
> NodeImpl::NodeImpl(DocumentImpl *ownerDoc)
> {
> - this->userData = null;
> this->flags = 0;
> // as long as we do not have any owner, ownerNode is our ownerDocument
> this->ownerNode = ownerDoc;
> @@ -107,7 +106,6 @@
> // deep clone
> NodeImpl::NodeImpl(const NodeImpl &other) {
> this->flags = other.flags;
> - this->userData = other.userData;
> this->isReadOnly(false);
>
> this->nodeRefCount = 0;
>
>
>
> 1.22 +2 -4 xml-xerces/c/src/dom/NodeImpl.hpp
>
> Index: NodeImpl.hpp
> ===================================================================
> RCS file: /home/cvs/xml-xerces/c/src/dom/NodeImpl.hpp,v
> retrieving revision 1.21
> retrieving revision 1.22
> diff -u -r1.21 -r1.22
> --- NodeImpl.hpp 2000/08/17 22:47:11 1.21
> +++ NodeImpl.hpp 2001/01/17 17:25:53 1.22
> @@ -58,7 +58,7 @@
> */
>
> /*
> - * $Id: NodeImpl.hpp,v 1.21 2000/08/17 22:47:11 lehors Exp $
> + * $Id: NodeImpl.hpp,v 1.22 2001/01/17 17:25:53 lehors Exp $
> */
>
> //
> @@ -126,9 +126,7 @@
> static const unsigned short IGNORABLEWS;
> static const unsigned short SETVALUE;
> static const unsigned short ID_ATTR;
> - static const unsigned short USERDATA;
> -
> - void *userData;
> + static const unsigned short USERDATA;
>
> static int gLiveNodeImpls; // Counters for debug & tuning.
> static int gTotalNodeImpls;
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: xerces-cvs-unsubscribe@xml.apache.org
> For additional commands, e-mail: xerces-cvs-help@xml.apache.org
Re: cvs commit: xml-xerces/c/src/dom NodeImpl.cpp NodeImpl.hpp
Posted by Arnaud Le Hors <le...@us.ibm.com>.
"Perry A. Caro" wrote:
>
> I was suprised by the change noticed included below. Does this mean
> userData on any node is no longer supported? We're using that field for
> user data.
Not at all. It's just that the user data is stored in a hashtable on the
document instead of on every node. This is already the way it's been
working for a while but the field itself on the node wasn't removed.
--
Arnaud Le Hors - IBM Cupertino, XML Strategy Group
RE: cvs commit: xml-xerces/c/src/dom NodeImpl.cpp NodeImpl.hpp
Posted by Linda Derezinski <li...@interfacecontrol.com>.
I was suprised by the change noticed included below. Does this mean
userData on any node is no longer supported? We're using that field for
user data.
So Are we.
Linda Derezinski
Interface & Control Systems