[GitHub] [netbeans] matthiasblaesing commented on pull request #3251: Including nb-javac binaries in all the complementary distributions

[GitBox <gi...@apache.org>]

matthiasblaesing commented on pull request #3251:
URL: https://github.com/apache/netbeans/pull/3251#issuecomment-964506675


   I did a first pass on the verification errors and pushed this (feel free to squash into your changes): https://github.com/matthiasblaesing/netbeans/tree/pr-3251
   
   There are four commits (I think the descriptions are self explaining):
   https://github.com/matthiasblaesing/netbeans/commit/08395c1f7a564012332cb4f46a7693cdecfef5ff
   https://github.com/matthiasblaesing/netbeans/commit/5e84be74a54a0cf698ee85b629270f9bdbb4223e
   https://github.com/matthiasblaesing/netbeans/commit/e2dd5f1bb200f4caf68f722cfdebae1d4bf1edb2
   https://github.com/matthiasblaesing/netbeans/commit/4c120ca0156294cd2ef31954a2690136d5f9162e
   
   The fourth needs an explanation why this is -CP save (see "Comment" fields changed there).
   
   Rebuilding from source from maven central fails and I though the build had a state, where a java compiler was used to build javac and not the some derived version (frgaal). My understanding was, that jackpot should be used to patch out all problems and then let the JDK8 or JDK11 javac do the work to compile its newer counter part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists