[GitHub] [ozone] prashantpogde commented on a diff in pull request #4264: HDDS-7950. [Snapshot] API changes to support pagination token and async nature of snapshot diff API

["prashantpogde (via GitHub)" <gi...@apache.org>]

prashantpogde commented on code in PR #4264:
URL: https://github.com/apache/ozone/pull/4264#discussion_r1109036686


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/snapshot/SnapshotDiffReport.java:
##########
@@ -182,9 +183,16 @@ public static DiffReportEntry fromProtobuf(
    */
   private final List<DiffReportEntry> diffList;
 
-  public SnapshotDiffReport(final String volumeName, final String bucketName,
-                            final String fromSnapshot, final String toSnapshot,
-                            List<DiffReportEntry> entryList) {
+  /**
+   * subsequent token for the diff report.
+   */
+  private final String token = null; //TODO: will set it properly in HDDS-7548

Review Comment:
   nitpick: TODO on a separate line on top. Let us also put "SNAPSHOT" label on all TODOs. We can scan for all pending Snapshot TODOs in our code base easily that way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org