You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by Mike Thomsen <mi...@gmail.com> on 2018/06/23 17:04:58 UTC
How would we handle this?
I found that Confluent has an Avro data generator project. Their code is
ASL 2.0 with the caveat that it has a GPL dependency and they reference a
GPL'd class in it. Can I bring this ASL 2.0 code into our code base or do I
have to treat it as GPL-tainted even if I remove the references to the one
annotation that was from a GPL'd library?
https://github.com/confluentinc/avro-random-generator/blob/master/src/main/java/io/confluent/avro/random/generator/Generator.java
Thanks,
Mike
Re: How would we handle this?
Posted by Mike Thomsen <mi...@gmail.com>.
I am going to send them a pull request since it looks like the only
contributors are Confluent employees. If they don't respond to that, I'll
go that route.
On Sat, Jun 23, 2018 at 2:16 PM Aldrin Piri <al...@gmail.com> wrote:
> Mike,
>
> That sounds fair and should be straightforward. Just be sure to update the
> LICENSE with the appropriate reference to the source as a derived work.
>
> On Sat, Jun 23, 2018 at 1:46 PM Mike Thomsen <mi...@gmail.com>
> wrote:
>
> > Aldrin,
> >
> > Ticket 5084 calls for a GenerateRecord processor, and this avro generator
> > does a really good job of handling that. As far as I can tell, the only
> GPL
> > issue there it uses one annotation from findbugs. I am thinking I can
> > resolve this by importing the one source file we need (the Generator.java
> > linked) and removing the references to the GPL'd dependency.
> >
> > Anyone know if that would cause us any problems? The source file in
> > question says it's ASL 2.0.
> >
> > Thanks,
> >
> > Mike
> >
> > On Sat, Jun 23, 2018 at 1:31 PM Aldrin Piri <al...@gmail.com>
> wrote:
> >
> > > Hi Mike,
> > >
> > > Be careful of the findbugs annotations. While there are other projects
> > > that are indeed ALv2, it appears the canonical repo has this as LGPL
> [2].
> > > Not sure if this is needed, but could be complicating in terms of the
> > > binary assemblies we would create.
> > >
> > > There is a cleanroom implementation [1], but not sure how this would
> fit
> > > into the intent of what you are trying to do.
> > >
> > > Could you share some context of how you would be incorporating that
> > source
> > > and/or library? Be sure to also consider all dependencies any target
> > > library would be incorporating.
> > >
> > > [1] https://github.com/stephenc/findbugs-annotations
> > > [2]
> > >
> > >
> >
> https://github.com/findbugsproject/findbugs/tree/master/findbugs/src/java/edu/umd/cs/findbugs/annotations
> > >
> > > On Sat, Jun 23, 2018 at 1:12 PM Mike Thomsen <mi...@gmail.com>
> > > wrote:
> > >
> > > > Disregard... There are apparently multiple projects out there that
> have
> > > the
> > > > same name and I found one that was GPL. The one this project uses
> > > > **appears** to be ASL 2.0, so I think we're good.
> > > >
> > > > On Sat, Jun 23, 2018 at 1:04 PM Mike Thomsen <mikerthomsen@gmail.com
> >
> > > > wrote:
> > > >
> > > > > I found that Confluent has an Avro data generator project. Their
> code
> > > is
> > > > > ASL 2.0 with the caveat that it has a GPL dependency and they
> > > reference a
> > > > > GPL'd class in it. Can I bring this ASL 2.0 code into our code base
> > or
> > > > do I
> > > > > have to treat it as GPL-tainted even if I remove the references to
> > the
> > > > one
> > > > > annotation that was from a GPL'd library?
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/confluentinc/avro-random-generator/blob/master/src/main/java/io/confluent/avro/random/generator/Generator.java
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Mike
> > > > >
> > > >
> > >
> >
>
Re: How would we handle this?
Posted by Aldrin Piri <al...@gmail.com>.
Mike,
That sounds fair and should be straightforward. Just be sure to update the
LICENSE with the appropriate reference to the source as a derived work.
On Sat, Jun 23, 2018 at 1:46 PM Mike Thomsen <mi...@gmail.com> wrote:
> Aldrin,
>
> Ticket 5084 calls for a GenerateRecord processor, and this avro generator
> does a really good job of handling that. As far as I can tell, the only GPL
> issue there it uses one annotation from findbugs. I am thinking I can
> resolve this by importing the one source file we need (the Generator.java
> linked) and removing the references to the GPL'd dependency.
>
> Anyone know if that would cause us any problems? The source file in
> question says it's ASL 2.0.
>
> Thanks,
>
> Mike
>
> On Sat, Jun 23, 2018 at 1:31 PM Aldrin Piri <al...@gmail.com> wrote:
>
> > Hi Mike,
> >
> > Be careful of the findbugs annotations. While there are other projects
> > that are indeed ALv2, it appears the canonical repo has this as LGPL [2].
> > Not sure if this is needed, but could be complicating in terms of the
> > binary assemblies we would create.
> >
> > There is a cleanroom implementation [1], but not sure how this would fit
> > into the intent of what you are trying to do.
> >
> > Could you share some context of how you would be incorporating that
> source
> > and/or library? Be sure to also consider all dependencies any target
> > library would be incorporating.
> >
> > [1] https://github.com/stephenc/findbugs-annotations
> > [2]
> >
> >
> https://github.com/findbugsproject/findbugs/tree/master/findbugs/src/java/edu/umd/cs/findbugs/annotations
> >
> > On Sat, Jun 23, 2018 at 1:12 PM Mike Thomsen <mi...@gmail.com>
> > wrote:
> >
> > > Disregard... There are apparently multiple projects out there that have
> > the
> > > same name and I found one that was GPL. The one this project uses
> > > **appears** to be ASL 2.0, so I think we're good.
> > >
> > > On Sat, Jun 23, 2018 at 1:04 PM Mike Thomsen <mi...@gmail.com>
> > > wrote:
> > >
> > > > I found that Confluent has an Avro data generator project. Their code
> > is
> > > > ASL 2.0 with the caveat that it has a GPL dependency and they
> > reference a
> > > > GPL'd class in it. Can I bring this ASL 2.0 code into our code base
> or
> > > do I
> > > > have to treat it as GPL-tainted even if I remove the references to
> the
> > > one
> > > > annotation that was from a GPL'd library?
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/confluentinc/avro-random-generator/blob/master/src/main/java/io/confluent/avro/random/generator/Generator.java
> > > >
> > > > Thanks,
> > > >
> > > > Mike
> > > >
> > >
> >
>
Re: How would we handle this?
Posted by Mike Thomsen <mi...@gmail.com>.
Aldrin,
Ticket 5084 calls for a GenerateRecord processor, and this avro generator
does a really good job of handling that. As far as I can tell, the only GPL
issue there it uses one annotation from findbugs. I am thinking I can
resolve this by importing the one source file we need (the Generator.java
linked) and removing the references to the GPL'd dependency.
Anyone know if that would cause us any problems? The source file in
question says it's ASL 2.0.
Thanks,
Mike
On Sat, Jun 23, 2018 at 1:31 PM Aldrin Piri <al...@gmail.com> wrote:
> Hi Mike,
>
> Be careful of the findbugs annotations. While there are other projects
> that are indeed ALv2, it appears the canonical repo has this as LGPL [2].
> Not sure if this is needed, but could be complicating in terms of the
> binary assemblies we would create.
>
> There is a cleanroom implementation [1], but not sure how this would fit
> into the intent of what you are trying to do.
>
> Could you share some context of how you would be incorporating that source
> and/or library? Be sure to also consider all dependencies any target
> library would be incorporating.
>
> [1] https://github.com/stephenc/findbugs-annotations
> [2]
>
> https://github.com/findbugsproject/findbugs/tree/master/findbugs/src/java/edu/umd/cs/findbugs/annotations
>
> On Sat, Jun 23, 2018 at 1:12 PM Mike Thomsen <mi...@gmail.com>
> wrote:
>
> > Disregard... There are apparently multiple projects out there that have
> the
> > same name and I found one that was GPL. The one this project uses
> > **appears** to be ASL 2.0, so I think we're good.
> >
> > On Sat, Jun 23, 2018 at 1:04 PM Mike Thomsen <mi...@gmail.com>
> > wrote:
> >
> > > I found that Confluent has an Avro data generator project. Their code
> is
> > > ASL 2.0 with the caveat that it has a GPL dependency and they
> reference a
> > > GPL'd class in it. Can I bring this ASL 2.0 code into our code base or
> > do I
> > > have to treat it as GPL-tainted even if I remove the references to the
> > one
> > > annotation that was from a GPL'd library?
> > >
> > >
> > >
> >
> https://github.com/confluentinc/avro-random-generator/blob/master/src/main/java/io/confluent/avro/random/generator/Generator.java
> > >
> > > Thanks,
> > >
> > > Mike
> > >
> >
>
Re: How would we handle this?
Posted by Aldrin Piri <al...@gmail.com>.
Hi Mike,
Be careful of the findbugs annotations. While there are other projects
that are indeed ALv2, it appears the canonical repo has this as LGPL [2].
Not sure if this is needed, but could be complicating in terms of the
binary assemblies we would create.
There is a cleanroom implementation [1], but not sure how this would fit
into the intent of what you are trying to do.
Could you share some context of how you would be incorporating that source
and/or library? Be sure to also consider all dependencies any target
library would be incorporating.
[1] https://github.com/stephenc/findbugs-annotations
[2]
https://github.com/findbugsproject/findbugs/tree/master/findbugs/src/java/edu/umd/cs/findbugs/annotations
On Sat, Jun 23, 2018 at 1:12 PM Mike Thomsen <mi...@gmail.com> wrote:
> Disregard... There are apparently multiple projects out there that have the
> same name and I found one that was GPL. The one this project uses
> **appears** to be ASL 2.0, so I think we're good.
>
> On Sat, Jun 23, 2018 at 1:04 PM Mike Thomsen <mi...@gmail.com>
> wrote:
>
> > I found that Confluent has an Avro data generator project. Their code is
> > ASL 2.0 with the caveat that it has a GPL dependency and they reference a
> > GPL'd class in it. Can I bring this ASL 2.0 code into our code base or
> do I
> > have to treat it as GPL-tainted even if I remove the references to the
> one
> > annotation that was from a GPL'd library?
> >
> >
> >
> https://github.com/confluentinc/avro-random-generator/blob/master/src/main/java/io/confluent/avro/random/generator/Generator.java
> >
> > Thanks,
> >
> > Mike
> >
>
Re: How would we handle this?
Posted by Mike Thomsen <mi...@gmail.com>.
Disregard... There are apparently multiple projects out there that have the
same name and I found one that was GPL. The one this project uses
**appears** to be ASL 2.0, so I think we're good.
On Sat, Jun 23, 2018 at 1:04 PM Mike Thomsen <mi...@gmail.com> wrote:
> I found that Confluent has an Avro data generator project. Their code is
> ASL 2.0 with the caveat that it has a GPL dependency and they reference a
> GPL'd class in it. Can I bring this ASL 2.0 code into our code base or do I
> have to treat it as GPL-tainted even if I remove the references to the one
> annotation that was from a GPL'd library?
>
>
> https://github.com/confluentinc/avro-random-generator/blob/master/src/main/java/io/confluent/avro/random/generator/Generator.java
>
> Thanks,
>
> Mike
>