You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/21 15:53:56 UTC
Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Bugs: MESOS-8473
https://issues.apache.org/jira/browse/MESOS-8473
Repository: mesos
Description
-------
This patch adds filtering of operations reported for `GET_OPERATIONS`
calls. A principal is allowed to view see all operations for which it
is allowed to see the role of the underlying resources.
Diffs
-----
src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
Diff: https://reviews.apache.org/r/67693/diff/1/
Testing
-------
`make check`
The added tests fails without the corresponding changes to the master and agent code.
Thanks,
Benjamin Bannier
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On July 5, 2018, 9:55 p.m., Chun-Hung Hsiao wrote:
> > src/master/http.cpp
> > Lines 3821 (patched)
> > <https://reviews.apache.org/r/67693/diff/3/?file=2044470#file2044470line3821>
> >
> > Do we want to:
> > 1. Simply skip such operations, as suggested in the code here, or
> > 2. Return an `InternalServerError` eventually, or
> > 3. Just `CHECK` that this shouldn't happen?
> > Ditto below.
> >
> > Please feel free to drop this if you think skipping is good enough.
>
> Benjamin Bannier wrote:
> Thanks for bringing this up.
>
> Since we here only are concerned with authorizing operations, I still think that skipping is a fair solution (we cannot show the operation without authorizing, but also do not need to render the response not useful with `InternalServerError`; we do not need to `CHECK` either I believe as that would introduce very hard coupling).
>
> I added a `WARNING` log with some details. Does that work?
Sounds good.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205755
-----------------------------------------------------------
On July 6, 2018, 7:37 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated July 6, 2018, 7:37 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
>
>
> Diff: https://reviews.apache.org/r/67693/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On July 5, 2018, 11:55 p.m., Chun-Hung Hsiao wrote:
> > src/master/http.cpp
> > Lines 3821 (patched)
> > <https://reviews.apache.org/r/67693/diff/3/?file=2044470#file2044470line3821>
> >
> > Do we want to:
> > 1. Simply skip such operations, as suggested in the code here, or
> > 2. Return an `InternalServerError` eventually, or
> > 3. Just `CHECK` that this shouldn't happen?
> > Ditto below.
> >
> > Please feel free to drop this if you think skipping is good enough.
Thanks for bringing this up.
Since we here only are concerned with authorizing operations, I still think that skipping is a fair solution (we cannot show the operation without authorizing, but also do not need to render the response not useful with `InternalServerError`; we do not need to `CHECK` either I believe as that would introduce very hard coupling).
I added a `WARNING` log with some details. Does that work?
> On July 5, 2018, 11:55 p.m., Chun-Hung Hsiao wrote:
> > src/tests/api_tests.cpp
> > Lines 131-134 (original), 131-134 (patched)
> > <https://reviews.apache.org/r/67693/diff/3/?file=2044472#file2044472line131>
> >
> > How about making the same change as you did in `AgentAPITest::post`?
> > ```
> > Future<v1::master::Response> post(
> > const process::PID<master::Master>& pid,
> > const v1::master::Call& call,
> > const ContentType& contentType,
> > const Credential& credential = DEFAULT_CREDENTIAL)
> > ```
Done, also adjusted usage in `*/MasterAPITest.GetOperations/*` below.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205755
-----------------------------------------------------------
On July 6, 2018, 9:37 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated July 6, 2018, 9:37 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
>
>
> Diff: https://reviews.apache.org/r/67693/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205755
-----------------------------------------------------------
src/master/http.cpp
Lines 3821 (patched)
<https://reviews.apache.org/r/67693/#comment288625>
Do we want to:
1. Simply skip such operations, as suggested in the code here, or
2. Return an `InternalServerError` eventually, or
3. Just `CHECK` that this shouldn't happen?
Ditto below.
Please feel free to drop this if you think skipping is good enough.
src/tests/api_tests.cpp
Lines 131-134 (original), 131-134 (patched)
<https://reviews.apache.org/r/67693/#comment288665>
How about making the same change as you did in `AgentAPITest::post`?
```
Future<v1::master::Response> post(
const process::PID<master::Master>& pid,
const v1::master::Call& call,
const ContentType& contentType,
const Credential& credential = DEFAULT_CREDENTIAL)
```
src/tests/api_tests.cpp
Lines 1015-1020 (patched)
<https://reviews.apache.org/r/67693/#comment288658>
Do we need this?
src/tests/api_tests.cpp
Lines 1149-1167 (patched)
<https://reviews.apache.org/r/67693/#comment288667>
If you change the `MasterAPITest::post` helper, we can use it here:
```
v1Response = post(master.get()->pid, v1Call, contentType, DEFAULT_CREDENTIAL_2)
.then(...);
```
src/tests/api_tests.cpp
Lines 7102-7107 (patched)
<https://reviews.apache.org/r/67693/#comment288669>
Do we need this?
src/tests/api_tests.cpp
Lines 7225-7243 (patched)
<https://reviews.apache.org/r/67693/#comment288666>
We can use the `AgentAPITest::post` helper here:
```
v1Response = post(agent.get()->pid, v1Call, contentType, DEFAULT_CREDENTIAL_2);
```
- Chun-Hung Hsiao
On June 21, 2018, 3:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 3:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67693/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205822
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67693']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67693
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67693/logs/mesos-tests-stdout.log):
```
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (805 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (601 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[ OK ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1323 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (804 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (803 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1006 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (601 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[ OK ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5161 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5164 ms)
[----------] 24 tests from DockerContainerizerTest (91650 ms total)
[----------] 1 test from HungDockerTest
[ RUN ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull
d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000B920CFB860.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000B920CFBAC0.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @0000023186F27980.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000002318704A988.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @0000023187C13220.
ERROR: 5 leaked mock objects found at program exit.
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67693/logs/mesos-tests-stderr.log):
```
I0706 20:36:20.447275 14860 authenticatee.cpp:299] Authentication success
I0706 20:36:20.447275 11616 master.cpp:9802] Successfully authenticated principal 'test-principal' at scheduler-f463ae6b-789f-476f-bd8e-e9a7be961e86@192.10.1.6:62400
I0706 20:36:20.448261 17472 sched.cpp:501] Successfully authenticated with master master@192.10.1.6:62400
I0706 20:36:20.449278 17740 master.cpp:2927] Received SUBSCRIBE call for framework 'default' at scheduler-f463ae6b-789f-476f-bd8e-e9a7be961e86@192.10.1.6:62400
I0706 20:36:20.450258 17740 master.cpp:2234] Authorizing framework principal 'test-principal' to receive offers for roles '{ * }'
I0706 20:36:20.451277 11616 master.cpp:3008] Subscribing framework default with checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0706 20:36:20.451277 11616 master.cpp:9993] Adding framework 4cb15d0b-efd7-4535-9680-2289d125182a-0000 (default) at scheduler-f463ae6b-789f-476f-bd8e-e9a7be961e86@192.10.1.6:62400 with roles { } suppressed
I0706 20:36:20.452257 15680 sched.cpp:749] Framework registered with 4cb15d0b-efd7-4535-9680-2289d125182a-0000
I0706 20:36:20.453259 15940 hierarchical.cpp:299] Added framework 4cb15d0b-efd7-4535-9680-2289d125182a-0000
E0706 20:36:20.548674 11616 slave.cpp:7289] EXIT with status 1: Failed to perform recovery: Collect failed: Failed to run 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat -H npipe:////./pipe/docker_engine ps -a': exited with status 1; stderr=''C:\Program' is not recognized as an internal or external command,
operable program or batch file.
'
If recovery failed due to a change in configuration and you want to
keep the current agent id, you might want to change the
`--reconfiguration_policy` flag to a more permissive value.
To restart this agent with a new agent id instead, do as follows:
rm -f C:\Users\jenkins\AppData\Local\Temp\9T2dFj\meta\slaves\latest
This ensures that the agent does not recover old live executors.
If you use the Docker containerizer and think that the Docker
daemon state is broken, you can try to clear it. But be careful:
these commands will erase all containers and images from this host,
not just those started by Mesos!
docker kill $(docker ps -q)
docker rm $(docker ps -a -q)
docker rmi $(docker images -q)
Finally, restart the agent.
```
- Mesos Reviewbot Windows
On July 6, 2018, 7:37 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated July 6, 2018, 7:37 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
>
>
> Diff: https://reviews.apache.org/r/67693/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205864
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On July 6, 2018, 7:37 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated July 6, 2018, 7:37 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
>
>
> Diff: https://reviews.apache.org/r/67693/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205883
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67693]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 6, 2018, 7:37 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated July 6, 2018, 7:37 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
>
>
> Diff: https://reviews.apache.org/r/67693/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/
-----------------------------------------------------------
(Updated July 6, 2018, 9:37 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Changes
-------
Addressed comments from Chun.
Bugs: MESOS-8473
https://issues.apache.org/jira/browse/MESOS-8473
Repository: mesos
Description
-------
This patch adds filtering of operations reported for `GET_OPERATIONS`
calls. A principal is allowed to view see all operations for which it
is allowed to see the role of the underlying resources.
Diffs (updated)
-----
src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692
Diff: https://reviews.apache.org/r/67693/diff/4/
Changes: https://reviews.apache.org/r/67693/diff/3-4/
Testing
-------
`make check`
The added tests fails without the corresponding changes to the master and agent code.
Thanks,
Benjamin Bannier
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205221
-----------------------------------------------------------
PASS: Mesos patch 67693 was successfully built and tested.
Reviews applied: `['67693']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67693
- Mesos Reviewbot Windows
On June 21, 2018, 3:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 3:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67693/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205251
-----------------------------------------------------------
PASS: Mesos patch 67693 was successfully built and tested.
Reviews applied: `['67693']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67693
- Mesos Reviewbot Windows
On June 21, 2018, 3:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 3:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67693/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205253
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67693]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 21, 2018, 3:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 3:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67693/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205190
-----------------------------------------------------------
PASS: Mesos patch 67693 was successfully built and tested.
Reviews applied: `['67693']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67693
- Mesos Reviewbot Windows
On June 21, 2018, 3:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 3:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67693/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205501
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On June 21, 2018, 5:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> -----------------------------------------------------------
>
> (Updated June 21, 2018, 5:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
>
>
> Diffs
> -----
>
> src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5
> src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c
> src/tests/api_tests.cpp 4d6b5b3e938faed934e875e23e29c67fd50b9d6f
>
>
> Diff: https://reviews.apache.org/r/67693/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> The added tests fails without the corresponding changes to the master and agent code.
>
>
> Thanks,
>
> Benjamin Bannier
>
>