You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2016/06/13 07:51:19 UTC
svn commit: r1748114 - in
/commons/proper/bcel/trunk/src/main/java/org/apache/bcel: classfile/
generic/ util/ verifier/
Author: ggregory
Date: Mon Jun 13 07:51:19 2016
New Revision: 1748114
URL: http://svn.apache.org/viewvc?rev=1748114&view=rev
Log:
Use Java 6's String#isEmpty().
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Field.java
commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/InnerClass.java
commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/JavaClass.java
commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Method.java
commons/proper/bcel/trunk/src/main/java/org/apache/bcel/generic/FieldGen.java
commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java
commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPathRepository.java
commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/MemorySensitiveClassPathRepository.java
commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/VerifierAppFrame.java
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Field.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Field.java?rev=1748114&r1=1748113&r2=1748114&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Field.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Field.java Mon Jun 13 07:51:19 2016
@@ -123,7 +123,7 @@ public final class Field extends FieldOr
// Get names from constant pool
access = Utility.accessToString(super.getAccessFlags());
- access = access.equals("") ? "" : (access + " ");
+ access = access.isEmpty() ? "" : (access + " ");
signature = Utility.signatureToString(getSignature());
name = getName();
StringBuilder buf = new StringBuilder(64); // CHECKSTYLE IGNORE MagicNumber
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/InnerClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/InnerClass.java?rev=1748114&r1=1748113&r2=1748114&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/InnerClass.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/InnerClass.java Mon Jun 13 07:51:19 2016
@@ -198,7 +198,7 @@ public final class InnerClass implements
inner_name = "(anonymous)";
}
String access = Utility.accessToString(inner_access_flags, true);
- access = access.equals("") ? "" : (access + " ");
+ access = access.isEmpty() ? "" : (access + " ");
return " " + access + inner_name + "=class " + inner_class_name + outer_class_name;
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/JavaClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/JavaClass.java?rev=1748114&r1=1748113&r2=1748114&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/JavaClass.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/JavaClass.java Mon Jun 13 07:51:19 2016
@@ -595,7 +595,7 @@ public class JavaClass extends AccessFla
@Override
public String toString() {
String access = Utility.accessToString(super.getAccessFlags(), true);
- access = access.equals("") ? "" : (access + " ");
+ access = access.isEmpty() ? "" : (access + " ");
StringBuilder buf = new StringBuilder(128);
buf.append(access).append(Utility.classOrInterface(super.getAccessFlags())).append(" ").append(
class_name).append(" extends ").append(
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Method.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Method.java?rev=1748114&r1=1748113&r2=1748114&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Method.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/classfile/Method.java Mon Jun 13 07:51:19 2016
@@ -185,7 +185,7 @@ public final class Method extends FieldO
ExceptionTable e = getExceptionTable();
if (e != null) {
String str = e.toString();
- if (!str.equals("")) {
+ if (!str.isEmpty()) {
buf.append("\n\t\tthrows ").append(str);
}
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/generic/FieldGen.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/generic/FieldGen.java?rev=1748114&r1=1748113&r2=1748114&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/generic/FieldGen.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/generic/FieldGen.java Mon Jun 13 07:51:19 2016
@@ -317,7 +317,7 @@ public class FieldGen extends FieldGenOr
String signature;
String access; // Short cuts to constant pool
access = Utility.accessToString(super.getAccessFlags());
- access = access.equals("") ? "" : (access + " ");
+ access = access.isEmpty() ? "" : (access + " ");
signature = super.getType().toString();
name = getName();
StringBuilder buf = new StringBuilder(32); // CHECKSTYLE IGNORE MagicNumber
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java?rev=1748114&r1=1748113&r2=1748114&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPath.java Mon Jun 13 07:51:19 2016
@@ -72,7 +72,7 @@ public class ClassPath {
List<PathEntry> list = new ArrayList<>();
for (StringTokenizer tok = new StringTokenizer(class_path, File.pathSeparator); tok.hasMoreTokens();) {
String path = tok.nextToken();
- if (!path.equals("")) {
+ if (!path.isEmpty()) {
File file = new File(path);
try {
if (file.exists()) {
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPathRepository.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPathRepository.java?rev=1748114&r1=1748113&r2=1748114&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPathRepository.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassPathRepository.java Mon Jun 13 07:51:19 2016
@@ -77,7 +77,7 @@ public class ClassPathRepository impleme
*/
@Override
public JavaClass loadClass(String className) throws ClassNotFoundException {
- if ((className == null) || className.equals("")) {
+ if ((className == null) || className.isEmpty()) {
throw new IllegalArgumentException("Invalid class name " + className);
}
className = className.replace('/', '.'); // Just in case, canonical form
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/MemorySensitiveClassPathRepository.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/MemorySensitiveClassPathRepository.java?rev=1748114&r1=1748113&r2=1748114&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/MemorySensitiveClassPathRepository.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/MemorySensitiveClassPathRepository.java Mon Jun 13 07:51:19 2016
@@ -83,7 +83,7 @@ public class MemorySensitiveClassPathRep
*/
@Override
public JavaClass loadClass(String className) throws ClassNotFoundException {
- if ((className == null) || className.equals("")) {
+ if ((className == null) || className.isEmpty()) {
throw new IllegalArgumentException("Invalid class name " + className);
}
className = className.replace('/', '.'); // Just in case, canonical form
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/VerifierAppFrame.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/VerifierAppFrame.java?rev=1748114&r1=1748113&r2=1748114&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/VerifierAppFrame.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/VerifierAppFrame.java Mon Jun 13 07:51:19 2016
@@ -318,7 +318,7 @@ public class VerifierAppFrame extends JF
void newFileMenuItem_actionPerformed( final ActionEvent e ) {
String classname = JOptionPane
.showInputDialog("Please enter the fully qualified name of a class or interface to verify:");
- if ((classname == null) || (classname.equals(""))) {
+ if ((classname == null) || (classname.isEmpty())) {
return;
}
VerifierFactory.getVerifier(classname); // let observers do the rest.