You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by enragedginger <gi...@git.apache.org> on 2015/09/07 20:36:36 UTC
[GitHub] spark pull request: Added R to the list of languages with "high-le...
GitHub user enragedginger opened a pull request:
https://github.com/apache/spark/pull/8646
Added R to the list of languages with "high-level API" support in the…
… main README.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/enragedginger/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8646
----
commit d9c1568952e3ca510e89161dad654d26b670d1c4
Author: Stephen Hopper <sh...@shopper-osx.local>
Date: 2015-09-07T18:36:14Z
Added R to the list of languages with "high-level API" support in the main README.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Added R to the list of languages with "high-le...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8646#issuecomment-138354343
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Added R to the list of languages with "high-le...
Posted by enragedginger <gi...@git.apache.org>.
Github user enragedginger commented on the pull request:
https://github.com/apache/spark/pull/8646#issuecomment-138357258
I just added another commit which makes some spelling / grammar updates to the quick-start MD file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOC] Added R to the list of languages with "h...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8646#issuecomment-138516728
[Test build #1727 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1727/consoleFull) for PR 8646 at commit [`a2c5fce`](https://github.com/apache/spark/commit/a2c5fce775a38a3251ad5c4fc0474f39b68b4fe0).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Added R to the list of languages with "high-le...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8646#discussion_r38878153
--- Diff: README.md ---
@@ -1,7 +1,7 @@
# Apache Spark
Spark is a fast and general cluster computing system for Big Data. It provides
-high-level APIs in Scala, Java, and Python, and an optimized engine that
+high-level APIs in Scala, Java, Python, and R, and an optimized engine that
--- End diff --
I'm not clear whether R is advertised as stable enough for general use?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOC] Added R to the list of languages with "h...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8646#issuecomment-138557810
[Test build #1727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1727/console) for PR 8646 at commit [`a2c5fce`](https://github.com/apache/spark/commit/a2c5fce775a38a3251ad5c4fc0474f39b68b4fe0).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class BlockFetchException(messages: String, throwable: Throwable)`
* `class DCT(JavaTransformer, HasInputCol, HasOutputCol):`
* `class SQLTransformer(JavaTransformer):`
* `class StopWordsRemover(JavaTransformer, HasInputCol, HasOutputCol):`
* `case class LimitNode(limit: Int, child: LocalNode) extends UnaryLocalNode `
* `case class UnionNode(children: Seq[LocalNode]) extends LocalNode `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOC] Added R to the list of languages with "h...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8646#discussion_r38905968
--- Diff: docs/quick-start.md ---
@@ -217,13 +217,13 @@ a cluster, as described in the [programming guide](programming-guide.html#initia
</div>
# Self-Contained Applications
-Now say we wanted to write a self-contained application using the Spark API. We will walk through a
-simple application in both Scala (with SBT), Java (with Maven), and Python.
+Suppose we wish to write a self-contained application using the Spark API. We will walk through a
+simple application in Scala (with sbt), Java (with Maven), and Python.
<div class="codetabs">
<div data-lang="scala" markdown="1">
-We'll create a very simple Spark application in Scala. So simple, in fact, that it's
+We'll create a very simple Spark application in Scala--so simple, in fact, that it's
--- End diff --
Fair enough about R. This LGTM. I would have put spaces around this dash but it's too small to bother with.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOC] Added R to the list of languages with "h...
Posted by enragedginger <gi...@git.apache.org>.
Github user enragedginger commented on a diff in the pull request:
https://github.com/apache/spark/pull/8646#discussion_r38880620
--- Diff: docs/quick-start.md ---
@@ -272,7 +272,7 @@ scalaVersion := "{{site.SCALA_VERSION}}"
libraryDependencies += "org.apache.spark" %% "spark-core" % "{{site.SPARK_VERSION}}"
{% endhighlight %}
-For sbt to work correctly, we'll need to layout `SimpleApp.scala` and `simple.sbt`
+For SBT to work correctly, we'll need to layout `SimpleApp.scala` and `simple.sbt`
--- End diff --
I've switched all usages of "SBT" back to "sbt". At one point in time, SBT stood for "Simple Build Tool," but I can't find any remaining evidence of that on their site, so I'm guessing they've moved away from that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Added R to the list of languages with "high-le...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8646#discussion_r38878140
--- Diff: docs/quick-start.md ---
@@ -272,7 +272,7 @@ scalaVersion := "{{site.SCALA_VERSION}}"
libraryDependencies += "org.apache.spark" %% "spark-core" % "{{site.SPARK_VERSION}}"
{% endhighlight %}
-For sbt to work correctly, we'll need to layout `SimpleApp.scala` and `simple.sbt`
+For SBT to work correctly, we'll need to layout `SimpleApp.scala` and `simple.sbt`
--- End diff --
sbt is lower-case. jar seems equally upper and lower case, so, fine to change but on the whole I tend to leave things like that. I think the other changes are OK but not sure I'd bother with things that aren't obviously wrong, like an Oxford comma.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [DOC] Added R to the list of languages with "h...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Added R to the list of languages with "high-le...
Posted by enragedginger <gi...@git.apache.org>.
Github user enragedginger commented on a diff in the pull request:
https://github.com/apache/spark/pull/8646#discussion_r38879866
--- Diff: README.md ---
@@ -1,7 +1,7 @@
# Apache Spark
Spark is a fast and general cluster computing system for Big Data. It provides
-high-level APIs in Scala, Java, and Python, and an optimized engine that
+high-level APIs in Scala, Java, Python, and R, and an optimized engine that
--- End diff --
R is listed in the first paragraph on [this page](http://spark.apache.org/docs/latest/index.html), so I figured it should be in the README.md as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Added R to the list of languages with "high-le...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8646#issuecomment-138368533
Although this is probably OK without a JIRA, that's exceptional. Please read https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark first. In particular this isn't tagged as `[DOCS]` for example. Minor stuff but I don't want to let people to skip this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org