You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:44:49 UTC
[GitHub] [incubator-nuttx] TE-Masatoshi-Ueno commented on a change in pull request #2201: gs2200m: Add function to get IWNWID / IWFREQ / IWSENS information
TE-Masatoshi-Ueno commented on a change in pull request #2201:
URL: https://github.com/apache/incubator-nuttx/pull/2201#discussion_r515843439
##########
File path: include/nuttx/wireless/gs2200m.h
##########
@@ -48,6 +48,7 @@
#include <nuttx/config.h>
#include <nuttx/irq.h>
#include <nuttx/wireless/ioctl.h>
+#include <nuttx/wireless/wireless.h>
Review comment:
Yes, I think it needed. Definitions of wireless.h is needed in nuttx/drivers/wireless/gs2200m.c and apps/wireless/gs2200m/gs2200m_main.c , so I add this include in include/nuttx/wireless/gs2200,h .
I plan to create new pull request to incubator-nuttx-apps correspond to this commit.
##########
File path: include/nuttx/wireless/gs2200m.h
##########
@@ -48,6 +48,7 @@
#include <nuttx/config.h>
#include <nuttx/irq.h>
#include <nuttx/wireless/ioctl.h>
+#include <nuttx/wireless/wireless.h>
Review comment:
I got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org