You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/17 10:26:00 UTC

[jira] [Commented] (NIFI-4786) Allow Expression Evaluation to Kinesis/Firehose Stream Name

    [ https://issues.apache.org/jira/browse/NIFI-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328595#comment-16328595 ] 

ASF GitHub Bot commented on NIFI-4786:
--------------------------------------

GitHub user SunSatION opened a pull request:

    https://github.com/apache/nifi/pull/2409

    NIFI-4786 - Allow Expression Evaluation to Kinesis/Firehose Stream Name

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SunSatION/nifi master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2409
    
----
commit a4e7e677d6f9b85fb872f5217532fb6cb082c2c2
Author: dorian.bugeja <do...@...>
Date:   2018-01-17T10:22:39Z

    NIFI-4786 - Allow Expression Evaluation to Kinesis/Firehose Stream Name

----


> Allow Expression Evaluation to Kinesis/Firehose Stream Name
> -----------------------------------------------------------
>
>                 Key: NIFI-4786
>                 URL: https://issues.apache.org/jira/browse/NIFI-4786
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: 1.5.0
>            Reporter: Dorian Bugeja
>            Priority: Minor
>              Labels: features, performance, pull-request-available
>             Fix For: 1.5.0
>
>         Attachments: NIFI_4786___Allow_Expression_Evaluation_to_Kinesis_Firehose_Stream_Name.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currenctly, the Stream name propoerty for both Firehose and Kinesis does not support the expression language. Routing can be performed based on an attribute of the flowfile and having a single component rather than multiple for each one. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)