[GitHub] [iceberg] openinx commented on a change in pull request #3185: Flink: Remove deprecated func "build"

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #3185:
URL: https://github.com/apache/iceberg/pull/3185#discussion_r717178504



##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -301,18 +301,6 @@ public Builder uidPrefix(String newPrefix) {
       return appendDummySink(committerStream);
     }
 
-    /**
-     * Append the iceberg sink operators to write records to iceberg table.
-     *
-     * @return {@link DataStreamSink} for sink.
-     * @deprecated this will be removed in 0.14.0; use {@link #append()} because its returned {@link DataStreamSink}
-     * has a more correct data type.
-     */
-    @Deprecated
-    public DataStreamSink<RowData> build() {
-      return chainIcebergOperators();
-    }
-

Review comment:
       We can not remove this `build` method in current version, in case of breaking the downstream flink application !  As the javadoc says,  0.14.0 is the correct release to remove this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org