You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2020/12/08 17:04:15 UTC
svn commit: r1884209 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java
Author: msahyoun
Date: Tue Dec 8 17:04:15 2020
New Revision: 1884209
URL: http://svn.apache.org/viewvc?rev=1884209&view=rev
Log:
PDFBOX-4723: don't use equals and hashCode; use identity comparison inherited from Object
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java?rev=1884209&r1=1884208&r2=1884209&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSStream.java Tue Dec 8 17:04:15 2020
@@ -25,11 +25,8 @@ import java.io.InputStream;
import java.io.OutputStream;
import java.util.ArrayList;
import java.util.HashSet;
-import java.util.Iterator;
import java.util.List;
-import java.util.Objects;
import java.util.Set;
-import java.util.Map.Entry;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -105,64 +102,6 @@ public class COSStream extends COSDictio
}
/**
- * {@inheritDoc}
- */
- @Override
- public boolean equals(Object o) {
- if (o == this)
- {
- return true;
- }
-
- if (!(o instanceof COSStream))
- {
- return false;
- }
-
- COSStream toBeCompared = (COSStream) o;
-
- if (toBeCompared.size() != size())
- {
- return false;
- }
-
- // compare dictionary content
- Iterator<Entry<COSName, COSBase>> iter = entrySet().iterator();
- while (iter.hasNext())
- {
- Entry<COSName, COSBase> entry = iter.next();
- COSName key = entry.getKey();
- COSBase value = entry.getValue();
-
- if (!toBeCompared.containsKey(key))
- {
- return false;
- }
- else if (value == null)
- {
- if (toBeCompared.getItem(key) != null)
- {
- return false;
- }
- }
- else if (!value.equals(toBeCompared.getItem(key)))
- {
- return false;
- }
- }
- // compare stream content
- return toBeCompared.toTextString().equals(toTextString());
- }
-
- /**
- * {@inheritDoc}
- */
- @Override
- public int hashCode() {
- return Objects.hash(items, randomAccess, scratchFile, isWriting);
- }
-
- /**
* Throws if the random access backing store has been closed. Helpful for catching cases where
* a user tries to use a COSStream which has outlived its COSDocument.
*/