[GitHub] [hbase] saintstack commented on a change in pull request #3071: HBASE-25679 Size of log queue metric is incorrect

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #3071:
URL: https://github.com/apache/hbase/pull/3071#discussion_r598017516



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
##########
@@ -256,7 +256,6 @@ private void dequeueCurrentLog() throws IOException {
     logQueue.remove(walGroupId);
     setCurrentPath(null);
     setPosition(0);
-    metrics.decrSizeOfLogQueue();

Review comment:
       I see it in here...
   
   ```
     public void remove(String walGroupId) {
       PriorityBlockingQueue<Path> queue = getQueue(walGroupId);
       if (queue == null || queue.isEmpty()) {
         return;
       }
       queue.remove();
       // Decrease size logQueue.
       this.metrics.decrSizeOfLogQueue();
       // Re-compute age of oldest wal metric.
       this.metrics.setOldestWalAge(getOldestWalAge());
     }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org