You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "dimas-b (via GitHub)" <gi...@apache.org> on 2026/06/11 17:45:17 UTC
[I] Remove `IcebergCatalogHandler.createTableDirectWithWriteDelegation()` [polaris]
dimas-b opened a new issue, #4709:
URL: https://github.com/apache/polaris/issues/4709
`IcebergCatalogHandler.createTableDirectWithWriteDelegation()` is not used on "prod" call paths. We should remove it and refactor tests to use "prod" methods.
Cf. https://github.com/apache/polaris/pull/4659/changes#r3391430766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove unused prod call paths in `IcebergCatalogHandler` [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain closed issue #4709: Remove unused prod call paths in `IcebergCatalogHandler`
URL: https://github.com/apache/polaris/issues/4709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove `IcebergCatalogHandler.createTableDirectWithWriteDelegation()` [polaris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4709:
URL: https://github.com/apache/polaris/issues/4709#issuecomment-5305241772
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment if you think it's still relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove `IcebergCatalogHandler.createTableDirectWithWriteDelegation()` [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on issue #4709:
URL: https://github.com/apache/polaris/issues/4709#issuecomment-4799513349
Re-opening after merging #4725 to address the other cases mentioned by @adutra above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove `IcebergCatalogHandler.createTableDirectWithWriteDelegation()` [polaris]
Posted by "Parasmishra788 (via GitHub)" <gi...@apache.org>.
Parasmishra788 commented on issue #4709:
URL: https://github.com/apache/polaris/issues/4709#issuecomment-4979274657
Hi @dimas-b @adutra — I'd like to pick this up, starting with the methods listed above.
Reading through IcebergCatalogHandler, the convenience overloads seem to split into two groups:
listTables(Namespace) / listNamespaces(Namespace) / listViews(Namespace) delegate to catalogHandlerUtils() directly, skipping the isFederated branch and the LocalIcebergCatalog pagination path that the paginated overloads (and IcebergCatalogAdapter) actually use. Removing these looks like a clear win — the tests currently exercise a path prod never takes.
The loadTable family (loadTable(id, snapshots), loadTableIfStale, loadTableWithAccessDelegation, loadTableWithAccessDelegationIfStale) all funnel into the 5-arg loadTable with hardcoded arguments, so there's no behavioural divergence — only extra API surface. Inlining them would expand ~16 call sites in AbstractIcebergCatalogHandlerAuthzTest to 5-arg calls plus .get(). Is that the outcome you want, or would a test helper be preferable there?
Plan is to start small with listViews (single call site) to confirm the pattern matches #4725, then listTables / listNamespaces, then the create/load methods in separate PRs. Does that split work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove `IcebergCatalogHandler.createTableDirectWithWriteDelegation()` [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b closed issue #4709: Remove `IcebergCatalogHandler.createTableDirectWithWriteDelegation()`
URL: https://github.com/apache/polaris/issues/4709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove `IcebergCatalogHandler.createTableDirectWithWriteDelegation()` [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on issue #4709:
URL: https://github.com/apache/polaris/issues/4709#issuecomment-4982701805
@Parasmishra788 : I'm fine multi-arg methods too. If you feel like adding helper method in test code, that's fine too from my POV.
Thanks for picking this up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove `IcebergCatalogHandler.createTableDirectWithWriteDelegation()` [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on issue #4709:
URL: https://github.com/apache/polaris/issues/4709#issuecomment-4980191283
Hi @Parasmishra788!
> Is that the outcome you want, or would a test helper be preferable there?
Personally I would be fine with the 5-arg method calls.
> Does that split work for you?
Yes I'm OK with that. Thanks for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove `IcebergCatalogHandler.createTableDirectWithWriteDelegation()` [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on issue #4709:
URL: https://github.com/apache/polaris/issues/4709#issuecomment-4689515817
There are many more:
```
listNamespaces(org.apache.iceberg.catalog.Namespace)
listTables(org.apache.iceberg.catalog.Namespace)
createTableDirect(org.apache.iceberg.catalog.Namespace, org.apache.iceberg.rest.requests.CreateTableRequest)
createTableDirectWithWriteDelegation
createTableStaged(org.apache.iceberg.catalog.Namespace, org.apache.iceberg.rest.requests.CreateTableRequest)
createTableStagedWithWriteDelegation
loadTable(org.apache.iceberg.catalog.TableIdentifier, java.lang.String)
loadTableIfStale
listViews(org.apache.iceberg.catalog.Namespace)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org