[GitHub] [airflow] potiuk commented on a change in pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #7485: [AIRFLOW-6866] Fix wrong export for Mac on Breeze
URL: https://github.com/apache/airflow/pull/7485#discussion_r382669653
 
 

 ##########
 File path: breeze
 ##########
 @@ -629,7 +629,7 @@ function parse_arguments() {
         -k|--stop-environment)
           COMMAND_TO_RUN="run_docker_compose"
           DOCKER_COMPOSE_COMMAND="down"
-          export EXTRA_DC_OPTIONS+=("--remove-orphans")
 
 Review comment:
   Not by default. MacOS comes with bundled 3.* series of bash (the current version is 5.*) due to bash moving from GPL2 to GPL3. Now they switched to zsh in catalina as default shell but default bash remains 3.* . it has a number of missing new syntax from modern bash :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services