You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/29 22:55:45 UTC
[GitHub] [incubator-mxnet] szha opened a new pull request #19040: [DOC] enable edit on github
szha opened a new pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040
## Description ##
enable edit on github button
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] enable edit on github button
## Comments ##
- the auto-generated API docs will need additional work to function correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 removed a comment on pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
ys2843 removed a comment on pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040#issuecomment-687693521
There are still some broken links in tutorials: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/api/python/docs/tutorials/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040#issuecomment-683932656
Link: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/api/python/docs/tutorials/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040#issuecomment-687693521
There are still some broken links in tutorials: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/api/python/docs/tutorials/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040#discussion_r483585724
##########
File path: docs/python_docs/python/scripts/conf.py
##########
@@ -237,6 +234,16 @@
# let the source file format to be xxx.ipynb instead of xxx.ipynb.txt
html_sourcelink_suffix = ''
+html_context = {
+ 'display_github': True,
+ 'github_user': 'apache',
+ 'github_repo': 'mxnet',
Review comment:
incubator-mxnet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 removed a comment on pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
ys2843 removed a comment on pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040#issuecomment-683932656
Link: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/api/python/docs/tutorials/
Looks like there is some missing github links.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040#issuecomment-687693521
There are still some broken links: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/api/python/docs/tutorials/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040#discussion_r483760494
##########
File path: docs/python_docs/python/scripts/conf.py
##########
@@ -237,6 +234,16 @@
# let the source file format to be xxx.ipynb instead of xxx.ipynb.txt
html_sourcelink_suffix = ''
+html_context = {
+ 'display_github': True,
+ 'github_user': 'apache',
+ 'github_repo': 'mxnet',
Review comment:
There is forward in the link and I think the link is future proof 😆
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040#issuecomment-683932656
Link: http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/api/python/docs/tutorials/
Looks like there is some missing github links.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040#issuecomment-683937520
@ys2843 right, I think those are due to the fact that the published files and the sources are not the same. this applies to md->ipynb, generated rst, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19040: [DOC] enable edit on github
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19040:
URL: https://github.com/apache/incubator-mxnet/pull/19040#issuecomment-683350405
Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-cpu, website, windows-gpu, sanity, centos-gpu, unix-gpu, windows-cpu, miscellaneous, centos-cpu, clang, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org